src/api.cc - Issue 21347: Make the debugger completely unload when the debug event listener is unregist...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 21347: Make the debugger completely unload when the debug event listener is unregist... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 11 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/api.cc

===================================================================

--- src/api.cc (revision 1255)

+++ src/api.cc (working copy)

@@ -2893,8 +2893,11 @@

EnsureInitialized("v8::Debug::SetDebugEventListener()");

ON_BAILOUT("v8::Debug::SetDebugEventListener()", return false);

HandleScope scope;

- i::Debugger::SetEventListener(i::Factory::NewProxy(FUNCTION_ADDR(that)),

- Utils::OpenHandle(*data));

+ i::Handle<i::Object> proxy = i::Factory::undefined_value();

+ if (that != NULL) {

+ proxy = i::Factory::NewProxy(FUNCTION_ADDR(that));

+ }

+ i::Debugger::SetEventListener(proxy, Utils::OpenHandle(*data));

return true;

}

« no previous file with comments | « no previous file | src/debug.h » ('j') | no next file with comments »