Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2127009: Cleanup a bunch of TODO(shess). (Closed)

Created:
10 years, 7 months ago by Scott Hess - ex-Googler
Modified:
9 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org
Base URL:
git://codf21.jail/chromium.git
Visibility:
Public.

Description

Cleanup a bunch of TODO(shess). The TODO on AutocompleteEditViewMac about the popup needing the field for placement and font got half done. The placement part just seemed too intrusive to be worthwhile, but the font part seemed reasonable to get rid of. The others are all either not sensible anymore, or were addressed without being removed, or have been in there long enough that if nobody has complained by now, their subject must not matter. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47732

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -54 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_mac.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_mac.mm View 5 chunks +10 lines, -20 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_mac_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup_view_mac.mm View 4 chunks +2 lines, -17 lines 0 comments Download
M chrome/browser/cocoa/autocomplete_text_field_editor.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/location_bar_view_mac.mm View 1 chunk +0 lines, -6 lines 1 comment Download
M chrome/browser/cocoa/styled_text_field.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/cocoa/styled_text_field_cell.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Scott Hess - ex-Googler
Due to your TODO in location_bar_view_mac.mm...
10 years, 7 months ago (2010-05-19 20:23:40 UTC) #1
Nico
10 years, 7 months ago (2010-05-19 20:34:52 UTC) #2
LG

http://codereview.chromium.org/2127009/diff/1/8
File chrome/browser/cocoa/location_bar_view_mac.mm (left):

http://codereview.chromium.org/2127009/diff/1/8#oldcode157
chrome/browser/cocoa/location_bar_view_mac.mm:157: // PageTransition::TYPED.
:-)

Powered by Google App Engine
This is Rietveld 408576698