Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: chrome/browser/cocoa/styled_text_field.mm

Issue 2127009: Cleanup a bunch of TODO(shess). (Closed) Base URL: git://codf21.jail/chromium.git
Patch Set: Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/styled_text_field.mm
diff --git a/chrome/browser/cocoa/styled_text_field.mm b/chrome/browser/cocoa/styled_text_field.mm
index bf2641c540c43b5bed132f673e18b4970f3d0cf7..8703575a1afd4d7a3bdabcc918e9b23c7ec684ef 100644
--- a/chrome/browser/cocoa/styled_text_field.mm
+++ b/chrome/browser/cocoa/styled_text_field.mm
@@ -49,10 +49,6 @@
[subview setFrame:frame];
// Make sure the selection remains visible.
- // TODO(shess) This could be janky if it jerks the visible region
- // around too much. I believe that text fields only scroll in
- // response to selection movement (continuing the selection past the
- // edge, or arrowing the cursor around).
[editor scrollRangeToVisible:[editor selectedRange]];
}

Powered by Google App Engine
This is Rietveld 408576698