chrome/browser/cocoa/autocomplete_text_field_editor.mm - Issue 2127009: Cleanup a bunch of TODO(shess).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/cocoa/autocomplete_text_field_editor.mm

Issue 2127009: Cleanup a bunch of TODO(shess). (Closed) Base URL: git://codf21.jail/chromium.git

Patch Set: Created 10 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/cocoa/autocomplete_text_field_editor.mm

diff --git a/chrome/browser/cocoa/autocomplete_text_field_editor.mm b/chrome/browser/cocoa/autocomplete_text_field_editor.mm

index 6b184bf8e9038292f5bcfbc155039df8ecea9182..4aa94ff79f03cb6d883ad7755fba471955bfc0ac 100644

--- a/chrome/browser/cocoa/autocomplete_text_field_editor.mm

+++ b/chrome/browser/cocoa/autocomplete_text_field_editor.mm

@@ -262,7 +262,6 @@ class Extension;

}

DCHECK_EQ(range.length, 0U);

- // TODO(shess): Beep on empty? I hate beeps, though.

// NOTE: If |aString| is empty, this intentionally replaces the

// selection with empty. This seems consistent with the case where

// the input contained a mixture of characters and the string ended