Issue 2127001: Makes shader translation a runtime switch....

Issue 2127001: Makes shader translation a runtime switch.... (Closed)

Created:
10 years, 7 months ago by greggman

Modified:
9 years, 7 months ago

Reviewers:
apatrick, apatrick_chromium

CC:
chromium-reviews, jam+cc_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, apatrick_chromium, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Makes shader translation a runtime switch. For WebGL the shader translation is off. For Pepper and other processes it is on. This will be removed and the tranlator will always be on at some point in the future TEST=More conformance tests pass, manually ran WebGL demos in Chrome. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47441

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+169 lines, -113 lines)			Patch
M	chrome/renderer/ggl/ggl.h	View	1 2 3 4	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/renderer/ggl/ggl.cc	View	1 2 3 4	4 chunks	+17 lines, -0 lines	0 comments	Download
M	chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc	View	2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	gpu/GLES2/gles2_command_buffer.h	View	1 2 3 4 5 6	1 chunk	+5 lines, -1 line	0 comments	Download
M	gpu/command_buffer/build_gles2_cmd_buffer.py	View	1 2 3 4 5 6	3 chunks	+6 lines, -7 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_c_lib_autogen.h	View	1 2 3 4 5 6	1 chunk	+2 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_cmd_helper_autogen.h	View	1 2 3 4 5 6	1 chunk	+3 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_implementation.cc	View	1 2 3 4 5 6	1 chunk	+12 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_implementation_autogen.h	View	1 2 3 4 5 6	1 chunk	+1 line, -3 lines	0 comments	Download
M	gpu/command_buffer/common/gles2_cmd_format_autogen.h	View	1 2 3 4 5 6	2 chunks	+23 lines, -13 lines	0 comments	Download
M	gpu/command_buffer/common/gles2_cmd_format_test_autogen.h	View	1 2 3 4 5 6	1 chunk	+6 lines, -4 lines	0 comments	Download
M	gpu/command_buffer/docs/gles2_cmd_format_docs.txt	View	1 2 3 4 5 6	4 chunks	+19 lines, -15 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	1 2 3 4 5 6	9 chunks	+69 lines, -37 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_autogen.h	View	1 2 3 4 5 6	1 chunk	+0 lines, -12 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h	View	1 2 3 4 5 6	1 chunk	+1 line, -7 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_validation_autogen.h	View	1 2 3 4 5 6	1 chunk	+0 lines, -1 line	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h	View	1 2 3 4 5 6	1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

apatrick

10 years, 7 months ago (2010-05-13 22:57:59 UTC) #2

lgtm

http://codereview.chromium.org/2127001/diff/17001/18001
File chrome/renderer/ggl/ggl.cc (right):

http://codereview.chromium.org/2127001/diff/17001/18001#newcode362
chrome/renderer/ggl/ggl.cc:362: 
extra line

Expand Messages | Collapse Messages