Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2122020: Fixes for GLES systems. (Closed)

Created:
10 years, 7 months ago by Alexey Marinichev
Modified:
9 years, 7 months ago
Reviewers:
piman
CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano, ericli, petkov+cc_chromium.org
Base URL:
ssh://git@chromiumos-git//autotest.git
Visibility:
Public.

Description

Fixes for GLES systems.

Patch Set 1 #

Total comments: 4

Patch Set 2 : don't define I915_WORKAROUND to 0 #

Patch Set 3 : ...and removed bogus #-I from Makefile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -45 lines) Patch
M client/deps/glbench/src/Makefile View 1 2 4 chunks +24 lines, -12 lines 0 comments Download
M client/deps/glbench/src/egl_stuff.cc View 4 chunks +16 lines, -7 lines 0 comments Download
M client/deps/glbench/src/main.h View 2 chunks +4 lines, -2 lines 0 comments Download
M client/deps/glbench/src/main.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M client/deps/glbench/src/teartest.h View 1 chunk +2 lines, -2 lines 0 comments Download
M client/deps/glbench/src/teartest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M client/deps/glbench/src/testbase.h View 1 chunk +1 line, -1 line 0 comments Download
M client/deps/glbench/src/testbase.cc View 1 chunk +1 line, -1 line 0 comments Download
M client/deps/glbench/src/textureupdatetest.cc View 1 chunk +1 line, -1 line 0 comments Download
M client/deps/glbench/src/utils.h View 2 chunks +2 lines, -4 lines 0 comments Download
M client/deps/glbench/src/varyingsandddxytest.cc View 1 4 chunks +5 lines, -7 lines 0 comments Download
M client/deps/glbench/src/windowmanagercompositingtest.cc View 1 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alexey Marinichev
Three tests need to be ported to GLES, will do that in a separate change.
10 years, 7 months ago (2010-05-24 21:35:06 UTC) #1
piman
http://codereview.chromium.org/2122020/diff/1/2 File client/deps/glbench/src/Makefile (right): http://codereview.chromium.org/2122020/diff/1/2#newcode26 client/deps/glbench/src/Makefile:26: LDFLAGS = -lbase -lrt -lgflags #-L../../../../../../chrome remove the comments ...
10 years, 7 months ago (2010-05-24 21:48:05 UTC) #2
Alexey Marinichev
http://codereview.chromium.org/2122020/diff/1/2 File client/deps/glbench/src/Makefile (right): http://codereview.chromium.org/2122020/diff/1/2#newcode26 client/deps/glbench/src/Makefile:26: LDFLAGS = -lbase -lrt -lgflags #-L../../../../../../chrome On 2010/05/24 21:48:05, ...
10 years, 7 months ago (2010-05-24 22:05:37 UTC) #3
piman
10 years, 7 months ago (2010-05-24 22:47:57 UTC) #4 
LGTM

Powered by Google App Engine
This is Rietveld 408576698