Issue 212051: Download in progress dialog:...

Issue 212051: Download in progress dialog:... (Closed)

Created:
11 years, 3 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com, John Grabowski, Paul Godavari, pam+watch_chromium.org, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Download in progress dialog: - Change hardcoded "Google Chrome" to product name. - Implement for GTK. BUG=21652 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26891

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+156 lines, -20 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/app_controller_mac.mm	View	1	3 chunks	+11 lines, -7 lines	0 comments	Download
M	chrome/browser/gtk/browser_window_gtk.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
A	chrome/browser/gtk/download_in_progress_dialog_gtk.h	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download
A	chrome/browser/gtk/download_in_progress_dialog_gtk.cc	View	1	1 chunk	+98 lines, -0 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.cc	View		5 chunks	+12 lines, -7 lines	0 comments	Download
M	chrome/chrome.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM http://codereview.chromium.org/212051/diff/1/5 File chrome/browser/gtk/download_in_progress_dialog_gtk.cc (right): http://codereview.chromium.org/212051/diff/1/5#newcode31 Line 31: l10n_util::GetStringFUTF8(IDS_SINGLE_DOWNLOAD_REMOVE_CONFIRM_WARNING, tears. Some languages have more complex ...

11 years, 3 months ago (2009-09-22 21:19:39 UTC) #2

Evan Stade

11 years, 3 months ago (2009-09-22 21:23:48 UTC) #3

http://codereview.chromium.org/212051/diff/1/5
File chrome/browser/gtk/download_in_progress_dialog_gtk.cc (right):

http://codereview.chromium.org/212051/diff/1/5#newcode57
Line 57: (GtkDialogFlags) (GTK_DIALOG_MODAL | GTK_DIALOG_NO_SEPARATOR),
On 2009/09/22 21:19:40, tony wrote:
> Nit: static_cast

Done.

http://codereview.chromium.org/212051/diff/1/4
File chrome/browser/gtk/download_in_progress_dialog_gtk.h (right):

http://codereview.chromium.org/212051/diff/1/4#newcode5
Line 5: #include "base/basictypes.h"
On 2009/09/22 21:19:40, tony wrote:
> Nit: Include guards

d'oh

Expand Messages | Collapse Messages