Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 212022: Disable extension startup tests on Mac, since they're causing it to hang. (Closed)

Created:
11 years, 3 months ago by Matt Perry
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Disable extension startup tests on Mac, since they're causing it to hang. BUG=22287 TEST=no TBR=erikkay Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26619

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/test/startup/startup_test.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Matt Perry
11 years, 3 months ago (2009-09-18 21:16:15 UTC) #1
Erik does not do reviews
11 years, 3 months ago (2009-09-18 21:18:02 UTC) #2
LGTM

On Fri, Sep 18, 2009 at 2:16 PM,  <mpcomplete@chromium.org> wrote:
> Reviewers: Erik Kay,
>
> Description:
> Disable extension startup tests on Mac, since they're causing it to hang.
>
> BUG=3D22287
> TEST=3Dno
> TBR=3Derikkay
>
> Please review this at http://codereview.chromium.org/212022
>
> Affected files:
> =A0M chrome/test/startup/startup_test.cc
>
>
> Index: chrome/test/startup/startup_test.cc
> diff --git a/chrome/test/startup/startup_test.cc
> b/chrome/test/startup/startup_test.cc
> index
> eac8173b5569b0b61264e45bc62d2dd6edd10a76..69035d828351b23849e9c1efc7265f0=
f2001d0d4
> 100644
> --- a/chrome/test/startup/startup_test.cc
> +++ b/chrome/test/startup/startup_test.cc
> @@ -160,6 +160,11 @@ TEST_F(StartupTest, PerfCold) {
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0UITest::DEFAULT_THEME);
> =A0}
>
> +#if defined(OS_MACOSX)
> +// TODO(mpcomplete): running these tests on a mac builder results in lea=
ked
> +// chrome processes, causing the build slave to hang.
> +// http://code.google.com/p/chromium/issues/detail?id=3D22287
> +#else
> =A0TEST_F(StartupTest, PerfExtensionEmpty) {
> =A0 SetUpWithFileURL();
> =A0 SetUpWithExtensionsProfile("empty");
> @@ -198,7 +203,7 @@ TEST_F(StartupTest, PerfExtensionContentScript50) {
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0false /* cold */, false /* not importa=
nt */,
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0UITest::DEFAULT_THEME);
> =A0}
> -
> +#endif
>
> =A0#if defined(OS_WIN)
> =A0// TODO(port): Enable gears tests on linux/mac once gears is working.
>
>
>

Powered by Google App Engine
This is Rietveld 408576698