Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: chrome/test/startup/startup_test.cc

Issue 212022: Disable extension startup tests on Mac, since they're causing it to hang. (Closed)
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/startup/startup_test.cc
diff --git a/chrome/test/startup/startup_test.cc b/chrome/test/startup/startup_test.cc
index eac8173b5569b0b61264e45bc62d2dd6edd10a76..69035d828351b23849e9c1efc7265f0f2001d0d4 100644
--- a/chrome/test/startup/startup_test.cc
+++ b/chrome/test/startup/startup_test.cc
@@ -160,6 +160,11 @@ TEST_F(StartupTest, PerfCold) {
UITest::DEFAULT_THEME);
}
+#if defined(OS_MACOSX)
+// TODO(mpcomplete): running these tests on a mac builder results in leaked
+// chrome processes, causing the build slave to hang.
+// http://code.google.com/p/chromium/issues/detail?id=22287
+#else
TEST_F(StartupTest, PerfExtensionEmpty) {
SetUpWithFileURL();
SetUpWithExtensionsProfile("empty");
@@ -198,7 +203,7 @@ TEST_F(StartupTest, PerfExtensionContentScript50) {
false /* cold */, false /* not important */,
UITest::DEFAULT_THEME);
}
-
+#endif
#if defined(OS_WIN)
// TODO(port): Enable gears tests on linux/mac once gears is working.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698