Add no_gc_sections parameter to fix bad_alloc linkage error on chromeos valgrind bots.

Fix bad_alloc linkage error on chromeos valgrind bots. part 1.
 Seems like some of test binaries are now big enough that gold cannot link  with gc-sectinos.
This CL add gyp variable to turn it off. I'll add this  flag to master.cfg in separate CL.

BUG=44241
TEST=chromeos valgrind bot should be able to link test binaries.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47351

[Nicolas Sylvain, 2010-05-15 00:57:11]

lgtm

On Fri, May 14, 2010 at 5:49 PM, <oshima@chromium.org> wrote:

> Reviewers: Nicolas Sylvain,
>
> Description:
> Fix bad_alloc linkage error on chromeos valgrind bots. part 1.
>  Seems like some of test binaries are now big enough that gold cannot link
>  with
> gc-sectinos.
> This CL add gyp variable to turn it off. I'll add this  flag to master.cfg
> in
> separate CL.
>
> BUG=44241
> TEST=chromeos valgrind bot should be able to link test binaries.
>
> Please review this at http://codereview.chromium.org/2112004/show
>
> SVN Base: http://src.chromium.org/git/chromium.git
>
> Affected files:
>  M build/common.gypi
>
>
> Index: build/common.gypi
> diff --git a/build/common.gypi b/build/common.gypi
> index
>
f457a2b20fd4f86a09fe299eeb4242630e77c713..0e66dba9609eba74df667ad9ce45cd88b7e2e7b7
> 100644
> --- a/build/common.gypi
> +++ b/build/common.gypi
> @@ -899,6 +899,13 @@
>           'Release_Base': {
>             'variables': {
>               'release_optimize%': '2',
> +              # Binaries become big and gold is unable to perform GC
> +              # and remove unused sections for some of test targets
> +              # on 32 bit platform.
> +              # (This is currently observed only in chromeos valgrind
> bots)
> +              # The following flag is to disable --gc-sections linker
> +              # option for these bots.
> +              'no_gc_sections%': 0,
>             },
>             'cflags': [
>               '-O>(release_optimize)',
> @@ -910,9 +917,13 @@
>               '-fdata-sections',
>               '-ffunction-sections',
>             ],
> -            'ldflags': [
> -              '-Wl,--gc-sections',
> -            ],
> +            'conditions' : [
> +              ['no_gc_sections==0', {
> +                'ldflags': [
> +                  '-Wl,--gc-sections',
> +                ],
> +              }],
> +            ]
>           },
>         },
>         'variants': {
>
>
>