Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2203)

Unified Diff: build/common.gypi

Issue 2112004: Add no_gc_sections parameter to fix bad_alloc linkage error on chromeos valgrind bots. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: " Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index f457a2b20fd4f86a09fe299eeb4242630e77c713..0e66dba9609eba74df667ad9ce45cd88b7e2e7b7 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -899,6 +899,13 @@
'Release_Base': {
'variables': {
'release_optimize%': '2',
+ # Binaries become big and gold is unable to perform GC
+ # and remove unused sections for some of test targets
+ # on 32 bit platform.
+ # (This is currently observed only in chromeos valgrind bots)
+ # The following flag is to disable --gc-sections linker
+ # option for these bots.
+ 'no_gc_sections%': 0,
},
'cflags': [
'-O>(release_optimize)',
@@ -910,9 +917,13 @@
'-fdata-sections',
'-ffunction-sections',
],
- 'ldflags': [
- '-Wl,--gc-sections',
- ],
+ 'conditions' : [
+ ['no_gc_sections==0', {
+ 'ldflags': [
+ '-Wl,--gc-sections',
+ ],
+ }],
+ ]
},
},
'variants': {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698