Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Side by Side Diff: build/common.gypi

Issue 2112004: Add no_gc_sections parameter to fix bad_alloc linkage error on chromeos valgrind bots. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: " Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 'variables': { 9 'variables': {
10 # .gyp files or targets should set chromium_code to 1 if they build 10 # .gyp files or targets should set chromium_code to 1 if they build
(...skipping 881 matching lines...) Expand 10 before | Expand all | Expand 10 after
892 # One can use '-gstabs' to enable building the debugging 892 # One can use '-gstabs' to enable building the debugging
893 # information in STABS format for breakpad's dumpsyms. 893 # information in STABS format for breakpad's dumpsyms.
894 ], 894 ],
895 'ldflags': [ 895 'ldflags': [
896 '-rdynamic', # Allows backtrace to resolve symbols. 896 '-rdynamic', # Allows backtrace to resolve symbols.
897 ], 897 ],
898 }, 898 },
899 'Release_Base': { 899 'Release_Base': {
900 'variables': { 900 'variables': {
901 'release_optimize%': '2', 901 'release_optimize%': '2',
902 # Binaries become big and gold is unable to perform GC
903 # and remove unused sections for some of test targets
904 # on 32 bit platform.
905 # (This is currently observed only in chromeos valgrind bots)
906 # The following flag is to disable --gc-sections linker
907 # option for these bots.
908 'no_gc_sections%': 0,
902 }, 909 },
903 'cflags': [ 910 'cflags': [
904 '-O>(release_optimize)', 911 '-O>(release_optimize)',
905 # Don't emit the GCC version ident directives, they just end up 912 # Don't emit the GCC version ident directives, they just end up
906 # in the .comment section taking up binary size. 913 # in the .comment section taking up binary size.
907 '-fno-ident', 914 '-fno-ident',
908 # Put data and code in their own sections, so that unused symbols 915 # Put data and code in their own sections, so that unused symbols
909 # can be removed at link time with --gc-sections. 916 # can be removed at link time with --gc-sections.
910 '-fdata-sections', 917 '-fdata-sections',
911 '-ffunction-sections', 918 '-ffunction-sections',
912 ], 919 ],
913 'ldflags': [ 920 'conditions' : [
914 '-Wl,--gc-sections', 921 ['no_gc_sections==0', {
915 ], 922 'ldflags': [
923 '-Wl,--gc-sections',
924 ],
925 }],
926 ]
916 }, 927 },
917 }, 928 },
918 'variants': { 929 'variants': {
919 'coverage': { 930 'coverage': {
920 'cflags': ['-fprofile-arcs', '-ftest-coverage'], 931 'cflags': ['-fprofile-arcs', '-ftest-coverage'],
921 'ldflags': ['-fprofile-arcs'], 932 'ldflags': ['-fprofile-arcs'],
922 }, 933 },
923 'profile': { 934 'profile': {
924 'cflags': ['-pg', '-g'], 935 'cflags': ['-pg', '-g'],
925 'ldflags': ['-pg'], 936 'ldflags': ['-pg'],
(...skipping 427 matching lines...) Expand 10 before | Expand all | Expand 10 after
1353 # and therefore SYMROOT, needs to be set at the project level. 1364 # and therefore SYMROOT, needs to be set at the project level.
1354 'SYMROOT': '<(DEPTH)/xcodebuild', 1365 'SYMROOT': '<(DEPTH)/xcodebuild',
1355 }, 1366 },
1356 } 1367 }
1357 1368
1358 # Local Variables: 1369 # Local Variables:
1359 # tab-width:2 1370 # tab-width:2
1360 # indent-tabs-mode:nil 1371 # indent-tabs-mode:nil
1361 # End: 1372 # End:
1362 # vim: set expandtab tabstop=2 shiftwidth=2: 1373 # vim: set expandtab tabstop=2 shiftwidth=2:
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698