Change BrowserBubble to use Close instead of CloseNow. This should make

Change BrowserBubble to use Close instead of CloseNow.  This should make
it less susceptible to crashes in certain use cases.
Remove a delay in destroying the widget that was added to work around 
the old crash.

BUG=18248
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26625

[sky, 2009-09-18 18:29:15]

You need to change browser_bubble_gtk too. Once you do that, LGTM.

[Erik does not do reviews, 2009-09-18 18:40:10]

good catch thanks.  fixed.

On Fri, Sep 18, 2009 at 11:29 AM,  <sky@chromium.org> wrote:
> You need to change browser_bubble_gtk too. Once you do that, LGTM.
>
> http://codereview.chromium.org/211027
>

[sky, 2009-09-18 19:16:31]

http://codereview.chromium.org/211027/diff/4001/3004
File chrome/browser/views/browser_bubble_gtk.cc (right):

http://codereview.chromium.org/211027/diff/4001/3004#newcode29
Line 29: views::WidgetGtk* pop = static_cast<views::WidgetGtk*>(popup_.get());
Don't forget to change the popup_.get() calls too.

[Erik does not do reviews, 2009-09-18 20:18:00]

I'm stumped.  Somehow this compiled on the trybot.  I have no clue how
that's possible.

Thanks for saving me a revert.

Erik


On Fri, Sep 18, 2009 at 12:16 PM,  <sky@chromium.org> wrote:
>
> http://codereview.chromium.org/211027/diff/4001/3004
> File chrome/browser/views/browser_bubble_gtk.cc (right):
>
> http://codereview.chromium.org/211027/diff/4001/3004#newcode29
> Line 29: views::WidgetGtk* pop =
> static_cast<views::WidgetGtk*>(popup_.get());
> Don't forget to change the popup_.get() calls too.
>
> http://codereview.chromium.org/211027
>