chrome/browser/views/browser_bubble.cc - Issue 211027: Change BrowserBubble to use Close instead of CloseNow. This should make

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/views/browser_bubble.cc

Issue 211027: Change BrowserBubble to use Close instead of CloseNow. This should make (Closed)

Patch Set: gtk Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/views/browser_bubble.cc

diff --git a/chrome/browser/views/browser_bubble.cc b/chrome/browser/views/browser_bubble.cc

index de6959b802acbee6c3676b28c960c0ab7466f517..42a3e7ffc680cc4eadc74795e78a32b9cdfb5fae 100644

--- a/chrome/browser/views/browser_bubble.cc

+++ b/chrome/browser/views/browser_bubble.cc

@@ -24,7 +24,8 @@ BrowserBubble::BrowserBubble(views::View* view, views::Widget* frame,

BrowserBubble::~BrowserBubble() {

DCHECK(!attached_);

- popup_->CloseNow();

+ popup_->Close();

// Don't call DetachFromBrowser from here. It needs to talk to the

// BrowserView to deregister itself, and if BrowserBubble is owned

// by a child of BrowserView, then it's possible that this stack frame