Issue 206012: Clean up the ifdefs on ARM....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 206012: Clean up the ifdefs on ARM.... (Closed)

Created:
11 years, 3 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Clean up the ifdefs on ARM. Ensure that we use ARMv5 instructions on ARMv6 and ARMv7 CPUs. Committed: http://code.google.com/p/v8/source/detail?r=2898

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -13 lines)			Patch
M	src/arm/codegen-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/constants-arm.h	View	1 chunk	+22 lines, -2 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	1 chunk	+3 lines, -10 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

11 years, 3 months ago (2009-09-15 13:47:35 UTC) #2

LGTM

http://codereview.chromium.org/206012/diff/1/4
File src/arm/macro-assembler-arm.cc (right):

http://codereview.chromium.org/206012/diff/1/4#newcode57
Line 57: # error "for thumb inter-working we require architecture v5t or above"
Maybe change comment to "for thumb inter-working we require architecture which
supports the blx instruction"

Expand Messages | Collapse Messages