Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Side by Side Diff: src/arm/macro-assembler-arm.cc

Issue 206012: Clean up the ifdefs on ARM.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/constants-arm.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2006-2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 46
47 // We always generate arm code, never thumb code, even if V8 is compiled to 47 // We always generate arm code, never thumb code, even if V8 is compiled to
48 // thumb, so we require inter-working support 48 // thumb, so we require inter-working support
49 #if defined(__thumb__) && !defined(USE_THUMB_INTERWORK) 49 #if defined(__thumb__) && !defined(USE_THUMB_INTERWORK)
50 #error "flag -mthumb-interwork missing" 50 #error "flag -mthumb-interwork missing"
51 #endif 51 #endif
52 52
53 53
54 // We do not support thumb inter-working with an arm architecture not supporting 54 // We do not support thumb inter-working with an arm architecture not supporting
55 // the blx instruction (below v5t) 55 // the blx instruction (below v5t)
56 #if defined(USE_THUMB_INTERWORK) 56 #if defined(USE_THUMB_INTERWORK) && !defined(CAN_USE_THUMB_INSTRUCTIONS)
57 #if !defined(__ARM_ARCH_5T__) && \ 57 # error "for thumb inter-working we require architecture v5t or above"
Søren Thygesen Gjesse 2009/09/15 13:47:35 Maybe change comment to "for thumb inter-working w
58 !defined(__ARM_ARCH_5TE__) && \
59 !defined(__ARM_ARCH_6__) && \
60 !defined(__ARM_ARCH_7A__) && \
61 !defined(__ARM_ARCH_7__)
62 // add tests for other versions above v5t as required
63 #error "for thumb inter-working we require architecture v5t or above"
64 #endif
65 #endif 58 #endif
66 59
67 60
68 // Using blx may yield better code, so use it when required or when available 61 // Using blx may yield better code, so use it when required or when available
69 #if defined(USE_THUMB_INTERWORK) || defined(__ARM_ARCH_5__) 62 #if defined(USE_THUMB_INTERWORK) || defined(CAN_USE_ARMV5_INSTRUCTIONS)
70 #define USE_BLX 1 63 #define USE_BLX 1
71 #endif 64 #endif
72 65
73 // Using bx does not yield better code, so use it only when required 66 // Using bx does not yield better code, so use it only when required
74 #if defined(USE_THUMB_INTERWORK) 67 #if defined(USE_THUMB_INTERWORK)
75 #define USE_BX 1 68 #define USE_BX 1
76 #endif 69 #endif
77 70
78 71
79 void MacroAssembler::Jump(Register target, Condition cond) { 72 void MacroAssembler::Jump(Register target, Condition cond) {
(...skipping 1101 matching lines...) Expand 10 before | Expand all | Expand 10 after
1181 } 1174 }
1182 1175
1183 1176
1184 void CodePatcher::Emit(Address addr) { 1177 void CodePatcher::Emit(Address addr) {
1185 masm()->emit(reinterpret_cast<Instr>(addr)); 1178 masm()->emit(reinterpret_cast<Instr>(addr));
1186 } 1179 }
1187 #endif // ENABLE_DEBUGGER_SUPPORT 1180 #endif // ENABLE_DEBUGGER_SUPPORT
1188 1181
1189 1182
1190 } } // namespace v8::internal 1183 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/constants-arm.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698