Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: o3d/DEPS_gyp

Issue 206006: Force inclusion of build/common.gypi for all chromium gyp files. (Closed)
Patch Set: 2nd round of feedback Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: o3d/DEPS_gyp
diff --git a/o3d/DEPS_gyp b/o3d/DEPS_gyp
index 2ed3f690ca79b67a44cef0518d6cf39df51c3816..53536680f568cf29c6ed4b83ec6efbce7d159375 100644
--- a/o3d/DEPS_gyp
+++ b/o3d/DEPS_gyp
@@ -145,6 +145,6 @@ hooks = [
{
# A change to a .gyp, .gypi, or to GYP itself shound run the generator.
"pattern": "\\.gypi?$|[/\\\\]src[/\\\\]tools[/\\\\]gyp[/\\\\]|MANIFEST$",
Mark Mentovai 2009/09/15 21:49:57 Fix the pattern here too to reference src/build/gy
- "action": ["python", "tools/gyp/gyp", "o3d/build/all.gyp", "--depth", "."],
+ "action": ["python", "build/gyp_o3d", "build/all.gyp", "--depth", "."],
Mark Mentovai 2009/09/15 21:49:57 Shouldn't this be o3d/build/gyp_o3d and o3d/build/
},
]

Powered by Google App Engine
This is Rietveld 408576698