Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 205023: Fixed and reenabled AppendRelativePathTest which was broken on Windows. (Closed)

Created:
11 years, 3 months ago by Fred
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fixed and reenabled AppendRelativePathTest which was broken on Windows. r26968

Patch Set 1 #

Patch Set 2 : Misdiagnosed unittest failure, this is the real fix. #

Patch Set 3 : Fixed remaining failing testcase #

Patch Set 4 : commented out troublesome testcase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M base/file_path_unittest.cc View 1 2 3 2 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mark Mentovai
LG, we're doing a tryserver run at http://codereview.chromium.org/209070.
11 years, 3 months ago (2009-09-22 18:57:16 UTC) #1
Fred
Okay, latest patch: http://codereview.chromium.org/205023 On Tue, Sep 22, 2009 at 12:55 PM, Mark Mentovai <mark@chromium.org> ...
11 years, 3 months ago (2009-09-22 20:26:09 UTC) #2
Fred
Phajdan has offered to help. Thanks! On Tue, Sep 22, 2009 at 1:25 PM, Frederick ...
11 years, 3 months ago (2009-09-23 17:14:11 UTC) #3
Mark Mentovai
11 years, 3 months ago (2009-09-23 20:33:54 UTC) #4 
r26968

Powered by Google App Engine
This is Rietveld 408576698