Issue 209070: Fix and reenable AppendRelativePathTest which was broken on Windows....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 209070: Fix and reenable AppendRelativePathTest which was broken on Windows.... (Closed)

Created:
11 years, 3 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
Fred

CC:
chromium-reviews_googlegroups.com, brettw, tim (not reviewing), Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix and reenable AppendRelativePathTest which was broken on Windows. Patch by Fred Akalin <akalin@gmail.com>; Review URL: http://codereview.chromium.org/205023 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26968

Patch Set 3 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -3 lines)			Patch
	M	base/file_path_unittest.cc	View	1 2	2 chunks	+13 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LG http://codereview.chromium.org/209070/diff/1/2 File base/file_path_unittest.cc (right): http://codereview.chromium.org/209070/diff/1/2#newcode491 Line 491: { { FPL("/"), FPL("/foo/bar/baz") }, FPL("foo\\bar\\baz")}, Fix ...

11 years, 3 months ago (2009-09-22 18:56:52 UTC) #1

Fred

11 years, 3 months ago (2009-09-22 19:37:30 UTC) #2

One test case still fails.  I'll fix the indentation and look at the failure,
which seems like a genuine issue.

On 2009/09/22 18:56:52, Mark Mentovai wrote:
> LG
> 
> http://codereview.chromium.org/209070/diff/1/2
> File base/file_path_unittest.cc (right):
> 
> http://codereview.chromium.org/209070/diff/1/2#newcode491
> Line 491: { { FPL("/"),             FPL("/foo/bar/baz") },   
> FPL("foo\\bar\\baz")},
> Fix indentation (bump the last column over two characters).
> 
> It's OK to use column 80, just don't use column 81.
> 
> Same on lines 514 and 515.
> 
> If this passes the try servers, I'll fix this for you on checkin.

Expand Messages | Collapse Messages

Issue 209070: Fix and reenable AppendRelativePathTest which was broken on Windows.... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages