Issue 2041002: Quick fix: explicitly specify /Ob0 to avoid inlining if InlineFunctionExpansi...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2041002: Quick fix: explicitly specify /Ob0 to avoid inlining if InlineFunctionExpansi... (Closed)

Created:
10 years, 7 months ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Alexander Potapenko, M-A Ruel

CC:
chromium-reviews, Lei Zhang, bradnelson

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Quick fix: explicitly specify /Ob0 to avoid inlining if InlineFunctionExpansion==0; add 'default' value This is a follow-up for http://codereview.chromium.org/1995004 Looks like InlineFunctionExpansion=0 means "default", not /Ob0 for MSVS... TEST=trybots, tried locally with "vim base/base.vcproj" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46682

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -4 lines)			Patch
	M	build/common.gypi	View	1 2	3 chunks	+26 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm with one nit http://codereview.chromium.org/2041002/diff/3001/4001 File build/common.gypi (right): http://codereview.chromium.org/2041002/diff/3001/4001#newcode629 build/common.gypi:629: 'conditions': [ Can you put ...

10 years, 7 months ago (2010-05-07 13:09:32 UTC) #2

Timur Iskhodzhanov

10 years, 7 months ago (2010-05-07 13:19:00 UTC) #4

Thank you!

http://codereview.chromium.org/2041002/diff/3001/4001
File build/common.gypi (right):

http://codereview.chromium.org/2041002/diff/3001/4001#newcode629
build/common.gypi:629: 'conditions': [
On 2010/05/07 13:09:33, Marc-Antoine Ruel wrote:
> Can you put a one line comment why this is necessary? (That '0' has no effect)

Done.

Expand Messages | Collapse Messages