Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Side by Side Diff: build/common.gypi

Issue 2041002: Quick fix: explicitly specify /Ob0 to avoid inlining if InlineFunctionExpansi... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 'variables': { 9 'variables': {
10 # .gyp files or targets should set chromium_code to 1 if they build 10 # .gyp files or targets should set chromium_code to 1 if they build
(...skipping 363 matching lines...) Expand 10 before | Expand all | Expand 10 after
374 'mac_debug_optimization%': '0', # Use -O0 unless overridden 374 'mac_debug_optimization%': '0', # Use -O0 unless overridden
375 # See http://msdn.microsoft.com/en-us/library/aa652360(VS.71).aspx 375 # See http://msdn.microsoft.com/en-us/library/aa652360(VS.71).aspx
376 'win_release_Optimization%': '2', # 2 = /Os 376 'win_release_Optimization%': '2', # 2 = /Os
377 'win_debug_Optimization%': '0', # 0 = /Od 377 'win_debug_Optimization%': '0', # 0 = /Od
378 # See http://msdn.microsoft.com/en-us/library/aa652367(VS.71).aspx 378 # See http://msdn.microsoft.com/en-us/library/aa652367(VS.71).aspx
379 'win_release_RuntimeLibrary%': '0', # 0 = /MT (nondebug static) 379 'win_release_RuntimeLibrary%': '0', # 0 = /MT (nondebug static)
380 'win_debug_RuntimeLibrary%': '1', # 1 = /MTd (debug static) 380 'win_debug_RuntimeLibrary%': '1', # 1 = /MTd (debug static)
381 # See http://msdn.microsoft.com/en-us/library/8wtf2dfz(VS.71).aspx 381 # See http://msdn.microsoft.com/en-us/library/8wtf2dfz(VS.71).aspx
382 'win_debug_RuntimeChecks%': '3', # 3 = all checks enabled, 0 = off 382 'win_debug_RuntimeChecks%': '3', # 3 = all checks enabled, 0 = off
383 # See http://msdn.microsoft.com/en-us/library/47238hez(VS.71).aspx 383 # See http://msdn.microsoft.com/en-us/library/47238hez(VS.71).aspx
384 'win_debug_InlineFunctionExpansion%': '0', # 0 = off 384 'win_debug_InlineFunctionExpansion%': '', # empty = default, 0 = off,
385 'win_release_InlineFunctionExpansion%': '2', # 2 = max 385 'win_release_InlineFunctionExpansion%': '2', # 1 = only __inline, 2 = max
386 386
387 'release_extra_cflags%': '', 387 'release_extra_cflags%': '',
388 'debug_extra_cflags%': '', 388 'debug_extra_cflags%': '',
389 'release_valgrind_build%': 0, 389 'release_valgrind_build%': 0,
390 }, 390 },
391 'conditions': [ 391 'conditions': [
392 ['branding=="Chrome"', { 392 ['branding=="Chrome"', {
393 'defines': ['GOOGLE_CHROME_BUILD'], 393 'defines': ['GOOGLE_CHROME_BUILD'],
394 }, { # else: branding!="Chrome" 394 }, { # else: branding!="Chrome"
395 'defines': ['CHROMIUM_BUILD'], 395 'defines': ['CHROMIUM_BUILD'],
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
618 'xcode_settings': { 618 'xcode_settings': {
619 'COPY_PHASE_STRIP': 'NO', 619 'COPY_PHASE_STRIP': 'NO',
620 'GCC_OPTIMIZATION_LEVEL': '<(mac_debug_optimization)', 620 'GCC_OPTIMIZATION_LEVEL': '<(mac_debug_optimization)',
621 'OTHER_CFLAGS': [ '<@(debug_extra_cflags)', ], 621 'OTHER_CFLAGS': [ '<@(debug_extra_cflags)', ],
622 }, 622 },
623 'msvs_settings': { 623 'msvs_settings': {
624 'VCCLCompilerTool': { 624 'VCCLCompilerTool': {
625 'Optimization': '<(win_debug_Optimization)', 625 'Optimization': '<(win_debug_Optimization)',
626 'PreprocessorDefinitions': ['_DEBUG'], 626 'PreprocessorDefinitions': ['_DEBUG'],
627 'BasicRuntimeChecks': '<(win_debug_RuntimeChecks)', 627 'BasicRuntimeChecks': '<(win_debug_RuntimeChecks)',
628 'InlineFunctionExpansion': '<(win_debug_InlineFunctionExpansion)',
629 'RuntimeLibrary': '<(win_debug_RuntimeLibrary)', 628 'RuntimeLibrary': '<(win_debug_RuntimeLibrary)',
629 'conditions': [
630 # According to MSVS, InlineFunctionExpansion=0 means
631 # "default inlining", not "/Ob0".
632 # Thus, we have to handle InlineFunctionExpansion==0 separately.
633 ['win_debug_InlineFunctionExpansion==0', {
634 'AdditionalOptions': ['/Ob0'],
635 }],
636 ['win_debug_InlineFunctionExpansion!=""', {
637 'InlineFunctionExpansion':
638 '<(win_debug_InlineFunctionExpansion)',
639 }],
640 ],
630 }, 641 },
631 'VCLinkerTool': { 642 'VCLinkerTool': {
632 'LinkIncremental': '<(msvs_debug_link_incremental)', 643 'LinkIncremental': '<(msvs_debug_link_incremental)',
633 }, 644 },
634 'VCResourceCompilerTool': { 645 'VCResourceCompilerTool': {
635 'PreprocessorDefinitions': ['_DEBUG'], 646 'PreprocessorDefinitions': ['_DEBUG'],
636 }, 647 },
637 }, 648 },
638 'conditions': [ 649 'conditions': [
639 ['OS=="linux"', { 650 ['OS=="linux"', {
640 'cflags': [ 651 'cflags': [
641 '<@(debug_extra_cflags)', 652 '<@(debug_extra_cflags)',
642 ], 653 ],
643 }], 654 }],
644 ], 655 ],
645 }, 656 },
646 'Release_Base': { 657 'Release_Base': {
647 'abstract': 1, 658 'abstract': 1,
648 'defines': [ 659 'defines': [
649 'NDEBUG', 660 'NDEBUG',
650 ], 661 ],
651 'xcode_settings': { 662 'xcode_settings': {
652 'DEAD_CODE_STRIPPING': 'YES', # -Wl,-dead_strip 663 'DEAD_CODE_STRIPPING': 'YES', # -Wl,-dead_strip
653 'GCC_OPTIMIZATION_LEVEL': '<(mac_release_optimization)', 664 'GCC_OPTIMIZATION_LEVEL': '<(mac_release_optimization)',
654 'OTHER_CFLAGS': [ '<@(release_extra_cflags)', ], 665 'OTHER_CFLAGS': [ '<@(release_extra_cflags)', ],
655 }, 666 },
656 'msvs_settings': { 667 'msvs_settings': {
657 'VCCLCompilerTool': { 668 'VCCLCompilerTool': {
658 'Optimization': '<(win_release_Optimization)', 669 'Optimization': '<(win_release_Optimization)',
659 'InlineFunctionExpansion': '<(win_release_InlineFunctionExpansion)',
660 'RuntimeLibrary': '<(win_release_RuntimeLibrary)', 670 'RuntimeLibrary': '<(win_release_RuntimeLibrary)',
671 'conditions': [
672 # According to MSVS, InlineFunctionExpansion=0 means
673 # "default inlining", not "/Ob0".
674 # Thus, we have to handle InlineFunctionExpansion==0 separately.
675 ['win_release_InlineFunctionExpansion==0', {
676 'AdditionalOptions': ['/Ob0'],
677 }],
678 ['win_release_InlineFunctionExpansion!=""', {
679 'InlineFunctionExpansion':
680 '<(win_release_InlineFunctionExpansion)',
681 }],
682 ],
661 }, 683 },
662 'VCLinkerTool': { 684 'VCLinkerTool': {
663 'LinkIncremental': '1', 685 'LinkIncremental': '1',
664 }, 686 },
665 }, 687 },
666 'conditions': [ 688 'conditions': [
667 ['release_valgrind_build==0', { 689 ['release_valgrind_build==0', {
668 'defines': ['NVALGRIND'], 690 'defines': ['NVALGRIND'],
669 }], 691 }],
670 ['win_use_allocator_shim==0', { 692 ['win_use_allocator_shim==0', {
(...skipping 647 matching lines...) Expand 10 before | Expand all | Expand 10 after
1318 # and therefore SYMROOT, needs to be set at the project level. 1340 # and therefore SYMROOT, needs to be set at the project level.
1319 'SYMROOT': '<(DEPTH)/xcodebuild', 1341 'SYMROOT': '<(DEPTH)/xcodebuild',
1320 }, 1342 },
1321 } 1343 }
1322 1344
1323 # Local Variables: 1345 # Local Variables:
1324 # tab-width:2 1346 # tab-width:2
1325 # indent-tabs-mode:nil 1347 # indent-tabs-mode:nil
1326 # End: 1348 # End:
1327 # vim: set expandtab tabstop=2 shiftwidth=2: 1349 # vim: set expandtab tabstop=2 shiftwidth=2:
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698