Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1995004: Make RuntimeLibrary adjustable for Win/Debug build (Closed)

Created:
10 years, 7 months ago by Timur Iskhodzhanov
Modified:
9 years, 6 months ago
CC:
chromium-reviews, Alexander Potapenko
Visibility:
Public.

Description

Make RuntimeLibrary adjustable for Win/Debug build TEST=trybot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46664

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M build/common.gypi View 1 2 3 3 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Timur Iskhodzhanov
Hi Brad, Lei, I'd like to make BasicRuntimeChecks compilation option adjustable for Debug build. In ...
10 years, 7 months ago (2010-05-06 13:45:00 UTC) #1
Timur Iskhodzhanov
Also added adjustable /ObX (inline functions) switch
10 years, 7 months ago (2010-05-06 14:08:14 UTC) #2
Lei Zhang
Looks ok to me, but I don't know much about Windows build flags. +maruel,nsylvain
10 years, 7 months ago (2010-05-06 18:41:39 UTC) #3
M-A Ruel
10 years, 7 months ago (2010-05-06 18:43:25 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698