Fix inlined keyed property load on ARM...

Fix inlined keyed property load on ARM

The change r4608 accidently disabled the inlined keyed load as the key/receiver registers was mixed up. Also make sure that the registers for the keyed load IC is not clobbered before bailout to deferred code. This adds one instriction to the inlined code path.

Committed: http://code.google.com/p/v8/source/detail?r=4629

[Erik Corry, 2010-05-10 10:16:48]

LGTM

http://codereview.chromium.org/2018005/diff/4001/1003
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/2018005/diff/4001/1003#newcode5635
src/arm/codegen-arm.cc:5635: __ ldr(ip,
Ip is a register that is used behind our backs by the macro assembler.  We are a
little lax about not making the assumption that we can use it for other things. 
In this case we are expecting it to be preserved across four instructions, one
of which is not even generated here (it's in the deferred object's Branch
method).  I would feel better if we used VirtualFrame::scratch0() for this.

http://codereview.chromium.org/2018005/diff/4001/1004
File src/arm/ic-arm.cc (right):

http://codereview.chromium.org/2018005/diff/4001/1004#newcode642
src/arm/ic-arm.cc:642: inline_end_address - 19 * Assembler::kInstrSize;
Can we give this 19/20 constant a name?

[Søren Thygesen Gjesse, 2010-05-10 10:45:26]

http://codereview.chromium.org/2018005/diff/4001/1003
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/2018005/diff/4001/1003#newcode5635
src/arm/codegen-arm.cc:5635: __ ldr(ip,
On 2010/05/10 10:16:48, Erik Corry wrote:
> Ip is a register that is used behind our backs by the macro assembler.  We are
a
> little lax about not making the assumption that we can use it for other
things. 
> In this case we are expecting it to be preserved across four instructions, one
> of which is not even generated here (it's in the deferred object's Branch
> method).  I would feel better if we used VirtualFrame::scratch0() for this.

Done.

http://codereview.chromium.org/2018005/diff/4001/1004
File src/arm/ic-arm.cc (right):

http://codereview.chromium.org/2018005/diff/4001/1004#newcode642
src/arm/ic-arm.cc:642: inline_end_address - 19 * Assembler::kInstrSize;
On 2010/05/10 10:16:48, Erik Corry wrote:
> Can we give this 19/20 constant a name?

Added constant kInlinedKeyedLoadInstructionsAfterPatchSite to the ARM code
generator.