Issue 200122: Remove code doing a no-op due to float -> int rounding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 200122: Remove code doing a no-op due to float -> int rounding. (Closed)

Created:
11 years, 3 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Remove code doing a no-op due to float -> int rounding. Make implicit float -> int/long conversions explicit. (Implicit float -> int conversions can be found by compiling with -Wconversion in gcc [versions 4.1.1 and 4.2.4, and surely many others].) Landing the patch for Jacob Mandelson, original review: http://codereview.chromium.org/201091 BUG=none TEST=app_unittests & base_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26119

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -42 lines)			Patch
M	base/process_util_linux.cc	View	3 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/gtk/back_forward_button_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/bookmark_bar_gtk.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_manager_gtk.cc	View	2 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/gtk/browser_window_gtk.cc	View	4 chunks	+13 lines, -7 lines	0 comments	Download
M	chrome/browser/gtk/download_item_gtk.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/gtk/slide_animator_gtk.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/gtk/tab_contents_drag_source.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/tabs/dragged_tab_gtk.cc	View	2 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/gtk/tabs/tab_gtk.cc	View	1 chunk	+8 lines, -4 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper_linux.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download