chrome/browser/gtk/slide_animator_gtk.cc - Issue 200122: Remove code doing a no-op due to float -> int rounding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/gtk/slide_animator_gtk.cc

Issue 200122: Remove code doing a no-op due to float -> int rounding. (Closed)

Patch Set: Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/gtk/slide_animator_gtk.cc

diff --git a/chrome/browser/gtk/slide_animator_gtk.cc b/chrome/browser/gtk/slide_animator_gtk.cc

index 0508f6f2907e25138b47917eea7a3298f3b80450..b6837fc9949a73c28df7c19c2afae74473b378e3 100644

--- a/chrome/browser/gtk/slide_animator_gtk.cc

+++ b/chrome/browser/gtk/slide_animator_gtk.cc

@@ -111,8 +111,8 @@ bool SlideAnimatorGtk::IsAnimating() {

}

void SlideAnimatorGtk::AnimationProgressed(const Animation* animation) {

- int showing_height = child_->allocation.height *

- animation_->GetCurrentValue();

+ int showing_height = static_cast<int>(child_->allocation.height *

+ animation_->GetCurrentValue());

if (direction_ == DOWN) {

gtk_fixed_move(GTK_FIXED(widget_.get()), child_, 0,

showing_height - child_->allocation.height);