chrome/browser/gtk/download_item_gtk.cc - Issue 200122: Remove code doing a no-op due to float -> int rounding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/gtk/download_item_gtk.cc

Issue 200122: Remove code doing a no-op due to float -> int rounding. (Closed)

Patch Set: Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/gtk/download_item_gtk.cc

diff --git a/chrome/browser/gtk/download_item_gtk.cc b/chrome/browser/gtk/download_item_gtk.cc

index 74e15f841547b67a61109116c914f3dbd3ef4dd2..b2a13eb1b759648d4e1cadc26d35212058fd041b 100644

--- a/chrome/browser/gtk/download_item_gtk.cc

+++ b/chrome/browser/gtk/download_item_gtk.cc

@@ -424,9 +424,9 @@ void DownloadItemGtk::AnimationProgressed(const Animation* animation) {

gtk_widget_queue_draw(progress_area_.get());

} else {

if (IsDangerous()) {

- int progress = (dangerous_hbox_full_width_ -

- dangerous_hbox_start_width_) *

- new_item_animation_->GetCurrentValue();

+ int progress = static_cast<int>((dangerous_hbox_full_width_ -

+ dangerous_hbox_start_width_) *

+ new_item_animation_->GetCurrentValue());

int showing_width = dangerous_hbox_start_width_ + progress;

gtk_widget_set_size_request(dangerous_hbox_, showing_width, -1);

} else {

« no previous file with comments | « chrome/browser/gtk/browser_window_gtk.cc ('k') | chrome/browser/gtk/slide_animator_gtk.cc » ('j') | no next file with comments »