Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 200105: Merge 26029 - The shell dialog code explicitly disables the browser HWND befo... (Closed)

Created:
11 years, 3 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
jcampan
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Merge 26029 - The shell dialog code explicitly disables the browser HWND before calling the Windows API to select a file. When the dialog is closed, the browser HWND gets a WM_ACTIVATE but is still disabled, which messes up with the focus restoration. This patch ensures we restore the focus explicitly when the browser HWND is reenabled to workaround that issue. BUG=3380 TEST=Set the focus on a page with scrollbars, rightclick to do a 'save as'. Close the dialog. The arrow keys should let you scroll the page. Accelerators such as CtrlT should still work. Test 'open a file', 'print' and the font selection dialog (in the options). When closing the dialog the focus should return to the view that last had focus. Review URL: http://codereview.chromium.org/195065 TBR=jcampan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26034

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -1 line) Patch
MM chrome/browser/views/shell_dialogs_win.cc View 5 chunks +42 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
laforge
11 years, 3 months ago (2009-09-11 22:28:47 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698