Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 195065: Fix focus bug with shell dialogs (Closed)

Created:
11 years, 3 months ago by jcampan
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

The shell dialog code explicitly disables the browser HWND before calling the Windows API to select a file. When the dialog is closed, the browser HWND gets a WM_ACTIVATE but is still disabled, which messes up with the focus restoration. This patch ensures we restore the focus explicitly when the browser HWND is reenabled to work-around that issue. BUG=3380 TEST=Set the focus on a page with scroll-bars, right-click to do a 'save as'. Close the dialog. The arrow keys should let you scroll the page. Accelerators such as Ctrl-T should still work. Test 'open a file', 'print' and the font selection dialog (in the options). When closing the dialog the focus should return to the view that last had focus. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26029

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -1 line) Patch
M chrome/browser/views/shell_dialogs_win.cc View 5 chunks +42 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jcampan
11 years, 3 months ago (2009-09-11 21:10:27 UTC) #1
Ben Goodger (Google)
11 years, 3 months ago (2009-09-11 22:13:04 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698