Issue 199076: Get more info in the logs when ErrorPageTest fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 199076: Get more info in the logs when ErrorPageTest fails. (Closed)

Created:
11 years, 3 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Get more info in the logs when ErrorPageTest fails. TEST=none BUG=19361 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25875

Patch Set 1 #

Total comments: 2

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	chrome/browser/errorpage_uitest.cc	View		2 chunks	+9 lines, -0 lines	2 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

11 years, 3 months ago (2009-09-10 17:48:42 UTC) #1

lgtm

http://codereview.chromium.org/199076/diff/1/2
File chrome/browser/errorpage_uitest.cc (right):

http://codereview.chromium.org/199076/diff/1/2#newcode22
Line 22: EXPECT_EQ(title, GetActiveTabTitle());
I'd remove 3 lines out of 4. I'll let you guess which ones.

http://codereview.chromium.org/199076/diff/1/2#newcode35
Line 35: LOG(ERROR) << "Could not find " << title_substring << " in "
Here too.

Expand Messages | Collapse Messages