Get more info in the logs when ErrorPageTest fails.

chrome/browser/errorpage_uitest.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/string_util.h"
 #include "chrome/test/automation/tab_proxy.h"
 #include "chrome/test/ui/ui_test.h"
 #include "chrome/browser/net/url_request_failed_dns_job.h"
 #include "chrome/browser/net/url_request_mock_http_job.h"
 #include "net/url_request/url_request_unittest.h"
 
 class ErrorPageTest : public UITest {
  protected:
   bool WaitForTitleMatching(const std::wstring& title) {
     for (int i = 0; i < 100; ++i) {
       if (GetActiveTabTitle() == title)
         return true;
       PlatformThread::Sleep(sleep_timeout_ms() / 10);
     }
+
+    // Print more info when things go wrong.
+    EXPECT_EQ(title, GetActiveTabTitle());

[M-A Ruel, 2009/09/10 17:48:42]

I'd remove 3 lines out of 4. I'll let you guess which ones.

+
     return false;
   }
   bool WaitForTitleContaining(const std::string& title_substring) {
     for (int i = 0; i < 100; ++i) {
       std::wstring title = GetActiveTabTitle();
       if (title.find(UTF8ToWide(title_substring)) != std::wstring::npos)
         return true;
       PlatformThread::Sleep(sleep_timeout_ms() / 10);
     }
+
+    // Print more info when things go wrong.
+    LOG(ERROR) << "Could not find " << title_substring << " in "

[M-A Ruel, 2009/09/10 17:48:42]

Here too.

+               << GetActiveTabTitle();
+
     return false;
   }
 };
 
 TEST_F(ErrorPageTest, DNSError_Basic) {
   GURL test_url(URLRequestFailedDnsJob::kTestUrl);
 
   // The first navigation should fail, and the second one should be the error
   // page.
   NavigateToURLBlockUntilNavigationsComplete(test_url, 2);
@@ skipping 149 matching lines @@
   // The first navigation should fail, and the second one should be the error
   // page.
   NavigateToURLBlockUntilNavigationsComplete(
       URLRequestMockHTTPJob::GetMockUrl(L"page404.html"), 2);
   EXPECT_TRUE(WaitForTitleContaining("page404.html"));
 
   GetActiveTab()->GoBack();
 
   EXPECT_TRUE(WaitForTitleMatching(L"Title Of Awesomeness"));
 }