Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5463)

Unified Diff: chrome/browser/errorpage_uitest.cc

Issue 199076: Get more info in the logs when ErrorPageTest fails. (Closed)
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/errorpage_uitest.cc
diff --git a/chrome/browser/errorpage_uitest.cc b/chrome/browser/errorpage_uitest.cc
index 409cca0eb240372177b060932ff823900b9d8027..8a9623d3ea7b72e7a97d99d6810c84212cab66af 100644
--- a/chrome/browser/errorpage_uitest.cc
+++ b/chrome/browser/errorpage_uitest.cc
@@ -17,6 +17,10 @@ class ErrorPageTest : public UITest {
return true;
PlatformThread::Sleep(sleep_timeout_ms() / 10);
}
+
+ // Print more info when things go wrong.
+ EXPECT_EQ(title, GetActiveTabTitle());
M-A Ruel 2009/09/10 17:48:42 I'd remove 3 lines out of 4. I'll let you guess wh
+
return false;
}
bool WaitForTitleContaining(const std::string& title_substring) {
@@ -26,6 +30,11 @@ class ErrorPageTest : public UITest {
return true;
PlatformThread::Sleep(sleep_timeout_ms() / 10);
}
+
+ // Print more info when things go wrong.
+ LOG(ERROR) << "Could not find " << title_substring << " in "
M-A Ruel 2009/09/10 17:48:42 Here too.
+ << GetActiveTabTitle();
+
return false;
}
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698