Issue 199035: Localize First Run Dialogs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 199035: Localize First Run Dialogs (Closed)

Created:
11 years, 3 months ago by jeremy

Modified:
9 years, 6 months ago

Reviewers:
TVL

CC:
chromium-reviews_googlegroups.com, John Grabowski

Visibility:
Public.

Description

Localize OS X First Run Dialogs * Uses the awesome ChromeUILocalizer infrastructure. * Also solves the issue of hard coded prodcut names. BUG=19160, 19651, 19176 TEST=First run dialog + it's progress dialog should now say "Chromium" instead of "Google Chrome".

Patch Set 1 #

Total comments: 2

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+159 lines, -28 lines)			Patch
M	chrome/app/generated_resources.grd	View	2 chunks	+26 lines, -1 line	1 comment	Download
M	chrome/app/nibs/FirstRunDialog.xib	View	17 chunks	+66 lines, -17 lines	0 comments	Download
M	chrome/app/nibs/ImportProgressDialog.xib	View	13 chunks	+58 lines, -9 lines	0 comments	Download
M	chrome/browser/cocoa/import_progress_dialog.mm	View	2 chunks	+7 lines, -1 line	1 comment	Download
M	chrome/chrome.gyp	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

TVL

11 years, 3 months ago (2009-09-07 21:08:11 UTC) #2

lg

http://codereview.chromium.org/199035/diff/1/2
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/199035/diff/1/2#newcode3311
Line 3311: <message name="IDS_FIRSTRUN_DLG_MAC_WINDOW_TITLE" desc="Window title
of First Run Title on OS X - displayed in Window title bar">
indent within the <if> tag.

http://codereview.chromium.org/199035/diff/1/5
File chrome/browser/cocoa/import_progress_dialog.mm (right):

http://codereview.chromium.org/199035/diff/1/5#newcode65
Line 65: l10n_util::GetString(IDS_PRODUCT_NAME));
l10n_util::GetStringUTF16() will do this into a string16 in one shot.

Expand Messages | Collapse Messages