Moved XMPP notifier library from chrome/browser/sync to chrome/common....

Moved XMPP notifier library from chrome/browser/sync to chrome/common/net.
BUG=None
TEST=No functional change


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46413

[cbentzel, 2010-05-04 17:46:20]

Sorry for the hijack, but are there plans to share the common networking
infrastructure with the rest of base for things like DNS lookups? Or are there
going to be two separate stacks for the forseeable future?

[akalin, 2010-05-04 17:56:16]

On 2010/05/04 17:46:20, cbentzel wrote:
> Sorry for the hijack, but are there plans to share the common networking
> infrastructure with the rest of base for things like DNS lookups? Or are there
> going to be two separate stacks for the forseeable future?

Yes, I'm hoping to trim down the notifier code as much as possible; there's a
lot of cruft and duplicated code in there. :( Network status detection is a big
chunk that can be easily replaced with net/network_change_notifier (I'm working
on this), DNS looks like another piece of low hanging fruit, and after that
there might be some misc. things we can chop off.  Beyond that, there are
efforts underway to make libjingle use the chrome stack in chrome.  I can e-mail
you more details if you'd like.

[cbentzel, 2010-05-04 18:05:30]

Excellent, thanks.

On Tue, May 4, 2010 at 10:56 AM, <akalin@chromium.org> wrote:

> On 2010/05/04 17:46:20, cbentzel wrote:
>
>> Sorry for the hijack, but are there plans to share the common networking
>> infrastructure with the rest of base for things like DNS lookups? Or are
>> there
>> going to be two separate stacks for the forseeable future?
>>
>
> Yes, I'm hoping to trim down the notifier code as much as possible; there's
> a
> lot of cruft and duplicated code in there. :( Network status detection is a
> big
> chunk that can be easily replaced with net/network_change_notifier (I'm
> working
> on this), DNS looks like another piece of low hanging fruit, and after that
> there might be some misc. things we can chop off.  Beyond that, there are
> efforts underway to make libjingle use the chrome stack in chrome.  I can
> e-mail
> you more details if you'd like.
>
>
> http://codereview.chromium.org/1956001/show
>

[akalin, 2010-05-04 20:56:14]

http://codereview.chromium.org/1956001/diff/52003/51088
File chrome/browser/sync/engine/all_status.cc (right):

http://codereview.chromium.org/1956001/diff/52003/51088#newcode17
chrome/browser/sync/engine/all_status.cc:17: #include
"chrome/common/net/notifier/listener/talk_mediator.h"
Make sure includes are still alphabetical, here and in similar places

http://codereview.chromium.org/1956001/diff/52003/51171
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/1956001/diff/52003/51171#newcode1667
chrome/chrome_tests.gypi:1667: 'target_name': 'notifier_unit_tests',
Where's the old version of this?  Shouldn't it be deleted?

[sanjeevr, 2010-05-04 21:17:42]

Made the changes, please take another look.

http://codereview.chromium.org/1956001/diff/52003/51088
File chrome/browser/sync/engine/all_status.cc (right):

http://codereview.chromium.org/1956001/diff/52003/51088#newcode17
chrome/browser/sync/engine/all_status.cc:17: #include
"chrome/common/net/notifier/listener/talk_mediator.h"
On 2010/05/04 20:56:14, akalin wrote:
> Make sure includes are still alphabetical, here and in similar places

Done.

http://codereview.chromium.org/1956001/diff/52003/51171
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/1956001/diff/52003/51171#newcode1667
chrome/chrome_tests.gypi:1667: 'target_name': 'notifier_unit_tests',
On 2010/05/04 20:56:14, akalin wrote:
> Where's the old version of this?  Shouldn't it be deleted?

Done.

[akalin, 2010-05-04 21:26:37]

Sorry, I didn't catch this last time. :(

http://codereview.chromium.org/1956001/diff/68003/66091
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/1956001/diff/68003/66091#newcode1667
chrome/chrome_tests.gypi:1667: 'target_name': 'notifier_unit_tests',
You'll need to add stuff in build/all.gyp to pull in notifier_unit_tests (i.e.,
wherevver sync_unit_tests is referenced)

[sanjeevr, 2010-05-04 21:44:51]

http://codereview.chromium.org/1956001/diff/68003/66091
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/1956001/diff/68003/66091#newcode1667
chrome/chrome_tests.gypi:1667: 'target_name': 'notifier_unit_tests',
On 2010/05/04 21:26:37, akalin wrote:
> You'll need to add stuff in build/all.gyp to pull in notifier_unit_tests
(i.e.,
> wherevver sync_unit_tests is referenced)

Done.

[akalin, 2010-05-04 21:49:05]

LGTM, assuming trybots pass

On 2010/05/04 21:44:51, sanjeevr wrote:
> http://codereview.chromium.org/1956001/diff/68003/66091
> File chrome/chrome_tests.gypi (right):
> 
> http://codereview.chromium.org/1956001/diff/68003/66091#newcode1667
> chrome/chrome_tests.gypi:1667: 'target_name': 'notifier_unit_tests',
> On 2010/05/04 21:26:37, akalin wrote:
> > You'll need to add stuff in build/all.gyp to pull in notifier_unit_tests
> (i.e.,
> > wherevver sync_unit_tests is referenced)
> 
> Done.