Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 19004: Change URLRequest to use a ref-counted buffer for actual IO.... (Closed)

Created:
11 years, 11 months ago by rvargas (doing something else)
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Change URLRequest to use a ref-counted buffer for actual IO. This will re-land http://codereview.chromium.org/18390 BUG=5325 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8847

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+383 lines, -232 lines) Patch
M chrome/browser/automation/url_request_slow_download_job.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/url_request_slow_download_job.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chrome_plugin_host.cc View 4 chunks +32 lines, -5 lines 0 comments Download
M chrome/browser/dom_ui/chrome_url_data_manager.cc View 7 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/download/download_file.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/download/download_file.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/download/save_file_manager.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/download/save_file_manager.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/download/save_package.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/net/url_fetcher.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/net/url_fetcher.cc View 4 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/plugin_process_host.cc View 6 chunks +11 lines, -8 lines 0 comments Download
M chrome/browser/renderer_host/async_resource_handler.h View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/renderer_host/async_resource_handler.cc View 1 5 chunks +37 lines, -16 lines 0 comments Download
M chrome/browser/renderer_host/buffered_resource_handler.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/buffered_resource_handler.cc View 1 7 chunks +24 lines, -11 lines 0 comments Download
M chrome/browser/renderer_host/cross_site_resource_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/cross_site_resource_handler.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/download_resource_handler.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/download_resource_handler.cc View 6 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/renderer_host/download_throttling_resource_handler.h View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/download_throttling_resource_handler.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/resource_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/safe_browsing_resource_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/safe_browsing_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/save_file_resource_handler.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/save_file_resource_handler.cc View 4 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/renderer_host/sync_resource_handler.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/sync_resource_handler.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/common/chrome_plugin_unittest.cc View 5 chunks +7 lines, -5 lines 0 comments Download
M chrome/common/net/url_request_intercept_job.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/net/url_request_intercept_job.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/bzip2_filter_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M net/base/completion_callback.h View 3 chunks +17 lines, -0 lines 0 comments Download
M net/base/filter.h View 3 chunks +4 lines, -3 lines 0 comments Download
M net/base/filter.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/base/gzip_filter_unittest.cc View 5 chunks +8 lines, -5 lines 0 comments Download
A + net/base/io_buffer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/sdch_filter_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/build/net.vcproj View 1 chunk +4 lines, -0 lines 0 comments Download
M net/http/http_cache.cc View 4 chunks +11 lines, -7 lines 0 comments Download
M net/http/http_cache_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_network_transaction.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_network_transaction.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M net/http/http_transaction.h View 1 chunk +4 lines, -1 line 0 comments Download
M net/http/http_transaction_unittest.h View 4 chunks +7 lines, -5 lines 0 comments Download
M net/http/http_transaction_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/net_lib.scons View 1 chunk +1 line, -0 lines 0 comments Download
M net/proxy/proxy_script_fetcher.cc View 4 chunks +5 lines, -2 lines 0 comments Download
M net/url_request/mime_sniffer_proxy.h View 3 chunks +7 lines, -2 lines 0 comments Download
M net/url_request/mime_sniffer_proxy.cc View 5 chunks +10 lines, -6 lines 0 comments Download
M net/url_request/url_request.h View 3 chunks +11 lines, -10 lines 0 comments Download
M net/url_request/url_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_file_dir_job.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_file_dir_job.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/url_request/url_request_file_job.h View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_file_job.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/url_request/url_request_http_job.h View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_http_job.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/url_request/url_request_inet_job.h View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_inet_job.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_job.h View 4 chunks +4 lines, -3 lines 0 comments Download
M net/url_request/url_request_job.cc View 5 chunks +6 lines, -4 lines 0 comments Download
M net/url_request/url_request_simple_job.h View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_simple_job.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_test_job.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_test_job.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/url_request/url_request_unittest.h View 6 chunks +9 lines, -6 lines 0 comments Download
M webkit/tools/test_shell/simple_resource_loader_bridge.cc View 6 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rvargas (doing something else)
I modified the ref counting on a few places (second patch of this cl vs ...
11 years, 11 months ago (2009-01-27 22:12:27 UTC) #1
darin (slow to review)
rs=me
11 years, 11 months ago (2009-01-28 19:13:06 UTC) #2
darin (slow to review)
11 years, 11 months ago (2009-01-28 19:25:02 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698