Change URLRequest to use a ref-counted buffer for actual IO....

chrome/common/chrome_plugin_unittest.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 // Tests exercising the Chrome Plugin API.
 
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/string_util.h"
 #include "chrome/browser/chrome_plugin_host.h"
 #include "chrome/browser/net/url_fetcher.h"
 #include "chrome/browser/profile.h"
 #include "chrome/common/chrome_plugin_lib.h"
 #include "chrome/test/chrome_plugin/test_chrome_plugin.h"
+#include "net/base/io_buffer.h"
 #include "net/url_request/url_request_test_job.h"
 #include "net/url_request/url_request_unittest.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
 const wchar_t kDocRoot[] = L"chrome/test/data";
 const char kPluginFilename[] = "test_chrome_plugin.dll";
+const int kResponseBufferSize = 4096;
 
 class ChromePluginTest : public testing::Test, public URLRequest::Delegate {
  public:
   ChromePluginTest()
       : request_(NULL),
+        response_buffer_(new net::IOBuffer(kResponseBufferSize)),
         plugin_(NULL),
         expected_payload_(NULL),
         request_context_(new TestURLRequestContext()) {
   }
 
   // Loads/unloads the chrome test plugin.
   void LoadPlugin();
   void UnloadPlugin();
 
   // Runs the test and expects the given payload as a response.  If expectation
@@ skipping 31 matching lines @@
 
     // Flush the message loop to make Purify happy.
     message_loop_.RunAllPending();
   }
  protected:
   MessageLoopForIO message_loop_;
 
   // Note: we use URLRequest (instead of URLFetcher) because this allows the
   // request to be intercepted.
   scoped_ptr<URLRequest> request_;
-  char response_buffer_[4096];
+  scoped_refptr<net::IOBuffer> response_buffer_;
   std::string response_data_;
 
   ChromePluginLib* plugin_;
   TestFuncParams::PluginFuncs test_funcs_;
   const TestResponsePayload* expected_payload_;
   scoped_refptr<URLRequestContext> request_context_;
 };
 
 static void STDCALL CPT_Complete(CPRequest* request, bool success,
                                  const std::string& raw_headers,
@@ skipping 59 matching lines @@
   request_->Start();
 
   MessageLoop::current()->Run();
 }
 
 void ChromePluginTest::OnResponseStarted(URLRequest* request) {
   DCHECK(request == request_);
 
   int bytes_read = 0;
   if (request_->status().is_success())
-    request_->Read(response_buffer_, sizeof(response_buffer_), &bytes_read);
+    request_->Read(response_buffer_, kResponseBufferSize, &bytes_read);
   OnReadCompleted(request_.get(), bytes_read);
 }
 
 void ChromePluginTest::OnReadCompleted(URLRequest* request, int bytes_read) {
   DCHECK(request == request_);
 
   do {
     if (!request_->status().is_success() || bytes_read <= 0)
       break;
-    response_data_.append(response_buffer_, bytes_read);
-  } while (request_->Read(response_buffer_, sizeof(response_buffer_),
-                          &bytes_read));
+    response_data_.append(response_buffer_->data(), bytes_read);
+  } while (request_->Read(response_buffer_, kResponseBufferSize, &bytes_read));
 
   if (!request_->status().is_io_pending()) {
     OnURLRequestComplete();
   }
 }
 
 void ChromePluginTest::OnURLRequestComplete() {
   if (expected_payload_) {
     EXPECT_TRUE(request_->status().is_success());
 
@@ skipping 96 matching lines @@
 // Tests that the plugin does not intercept its own requests.
 TEST_F(ChromePluginTest, DoesNotInterceptOwnRequest) {
   const TestResponsePayload& payload = kChromeTestPluginPayloads[0];
 
   EXPECT_EQ(CPERR_SUCCESS, test_funcs_.test_make_request(
       "GET", GURL(payload.url)));
 
   MessageLoop::current()->Run();
 }