Issue 18540: Don't expose the go and star button views directly through the BrowserWindow ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18540: Don't expose the go and star button views directly through the BrowserWindow ... (Closed)

Created:
11 years, 11 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Don't expose the go and star button views directly through the BrowserWindow interface (for porting). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8572

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+102 lines, -95 lines)			Patch
M	chrome/browser/browser.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/browser.cc	View	1	6 chunks	+9 lines, -42 lines	0 comments	Download
M	chrome/browser/browser_commands_unittest.cc	View		2 chunks	+25 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_window.h	View	1 2	5 chunks	+14 lines, -12 lines	0 comments	Download
M	chrome/browser/browser_window_cocoa.h	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/browser_window_cocoa.mm	View		4 chunks	+13 lines, -4 lines	0 comments	Download
M	chrome/browser/dock_info.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/frame/browser_view.h	View		3 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.cc	View		8 chunks	+23 lines, -17 lines	0 comments	Download
M	chrome/browser/views/info_bubble.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/tabs/dragged_tab_controller.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/test/test_browser_window.h	View		2 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

11 years, 11 months ago (2009-01-23 18:35:47 UTC) #2

LGTM

http://codereview.chromium.org/18540/diff/207/209
File chrome/browser/browser_window.h (right):

http://codereview.chromium.org/18540/diff/207/209#newcode154
Line 154: // A BrowserWindow utility interface used for accessing elements of
thebtw browser
Looks like you tried to type in a chat window and it went in your editor.

Expand Messages | Collapse Messages