Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: chrome/browser/views/frame/browser_view.h

Issue 18540: Don't expose the go and star button views directly through the BrowserWindow ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/dock_info.cc ('k') | chrome/browser/views/frame/browser_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_VIEWS_FRAME_BROWSER_VIEW_H_ 5 #ifndef CHROME_BROWSER_VIEWS_FRAME_BROWSER_VIEW_H_
6 #define CHROME_BROWSER_VIEWS_FRAME_BROWSER_VIEW_H_ 6 #define CHROME_BROWSER_VIEWS_FRAME_BROWSER_VIEW_H_
7 7
8 #include "chrome/browser/browser.h" 8 #include "chrome/browser/browser.h"
9 #include "chrome/browser/browser_window.h" 9 #include "chrome/browser/browser_window.h"
10 #include "chrome/browser/hang_monitor/hung_plugin_action.h" 10 #include "chrome/browser/hang_monitor/hung_plugin_action.h"
(...skipping 27 matching lines...) Expand all
38 public NotificationObserver, 38 public NotificationObserver,
39 public TabStripModelObserver, 39 public TabStripModelObserver,
40 public views::WindowDelegate, 40 public views::WindowDelegate,
41 public views::ClientView { 41 public views::ClientView {
42 public: 42 public:
43 explicit BrowserView(Browser* browser); 43 explicit BrowserView(Browser* browser);
44 virtual ~BrowserView(); 44 virtual ~BrowserView();
45 45
46 void set_frame(BrowserFrame* frame) { frame_ = frame; } 46 void set_frame(BrowserFrame* frame) { frame_ = frame; }
47 47
48 // Returns a pointer to the BrowserWindow* interface implementation (an 48 // Returns a pointer to the BrowserView* interface implementation (an
49 // instance of this object, typically) for a given HWND, or NULL if there is 49 // instance of this object, typically) for a given HWND, or NULL if there is
50 // no such association. 50 // no such association.
51 static BrowserWindow* GetBrowserWindowForHWND(HWND window); 51 static BrowserView* GetBrowserViewForHWND(HWND window);
52 52
53 // Returns the show flag that should be used to show the frame containing 53 // Returns the show flag that should be used to show the frame containing
54 // this view. 54 // this view.
55 int GetShowState() const; 55 int GetShowState() const;
56 56
57 // Called by the frame to notify the BrowserView that it was moved, and that 57 // Called by the frame to notify the BrowserView that it was moved, and that
58 // any dependent popup windows should be repositioned. 58 // any dependent popup windows should be repositioned.
59 void WindowMoved(); 59 void WindowMoved();
60 60
61 // Returns the bounds of the toolbar, in BrowserView coordinates. 61 // Returns the bounds of the toolbar, in BrowserView coordinates.
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 148
149 // Overridden from BrowserWindow: 149 // Overridden from BrowserWindow:
150 virtual void Init(); 150 virtual void Init();
151 virtual void Show(); 151 virtual void Show();
152 virtual void SetBounds(const gfx::Rect& bounds); 152 virtual void SetBounds(const gfx::Rect& bounds);
153 virtual void Close(); 153 virtual void Close();
154 virtual void Activate(); 154 virtual void Activate();
155 virtual void FlashFrame(); 155 virtual void FlashFrame();
156 virtual void* GetNativeHandle(); 156 virtual void* GetNativeHandle();
157 virtual BrowserWindowTesting* GetBrowserWindowTesting(); 157 virtual BrowserWindowTesting* GetBrowserWindowTesting();
158 virtual TabStrip* GetTabStrip() const;
159 virtual StatusBubble* GetStatusBubble(); 158 virtual StatusBubble* GetStatusBubble();
160 virtual void SelectedTabToolbarSizeChanged(bool is_animating); 159 virtual void SelectedTabToolbarSizeChanged(bool is_animating);
161 virtual void UpdateTitleBar(); 160 virtual void UpdateTitleBar();
162 virtual void UpdateLoadingAnimations(bool should_animate); 161 virtual void UpdateLoadingAnimations(bool should_animate);
162 virtual void SetStarredState(bool is_starred);
163 virtual gfx::Rect GetNormalBounds() const; 163 virtual gfx::Rect GetNormalBounds() const;
164 virtual bool IsMaximized(); 164 virtual bool IsMaximized();
165 virtual ToolbarStarToggle* GetStarButton() const;
166 virtual LocationBarView* GetLocationBarView() const; 165 virtual LocationBarView* GetLocationBarView() const;
167 virtual GoButton* GetGoButton() const;
168 virtual BrowserView* GetBrowserView() const; 166 virtual BrowserView* GetBrowserView() const;
167 virtual void UpdateStopGoState(bool is_loading);
169 virtual void UpdateToolbar(TabContents* contents, bool should_restore_state); 168 virtual void UpdateToolbar(TabContents* contents, bool should_restore_state);
170 virtual void FocusToolbar(); 169 virtual void FocusToolbar();
171 virtual void DestroyBrowser(); 170 virtual void DestroyBrowser();
172 virtual bool IsBookmarkBarVisible() const; 171 virtual bool IsBookmarkBarVisible() const;
173 virtual void ToggleBookmarkBar(); 172 virtual void ToggleBookmarkBar();
174 virtual void ShowAboutChromeDialog(); 173 virtual void ShowAboutChromeDialog();
175 virtual void ShowBookmarkManager(); 174 virtual void ShowBookmarkManager();
175 virtual bool IsBookmarkBubbleVisible() const;
176 virtual void ShowBookmarkBubble(const GURL& url, bool already_bookmarked);
176 virtual void ShowReportBugDialog(); 177 virtual void ShowReportBugDialog();
177 virtual void ShowClearBrowsingDataDialog(); 178 virtual void ShowClearBrowsingDataDialog();
178 virtual void ShowImportDialog(); 179 virtual void ShowImportDialog();
179 virtual void ShowSearchEnginesDialog(); 180 virtual void ShowSearchEnginesDialog();
180 virtual void ShowPasswordManager(); 181 virtual void ShowPasswordManager();
181 virtual void ShowHTMLDialog(HtmlDialogContentsDelegate* delegate, 182 virtual void ShowHTMLDialog(HtmlDialogContentsDelegate* delegate,
182 void* parent_window); 183 void* parent_window);
183 184
184 // Overridden from BrowserWindowTesting: 185 // Overridden from BrowserWindowTesting:
185 virtual BookmarkBarView* GetBookmarkBarView(); 186 virtual BookmarkBarView* GetBookmarkBarView();
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
408 // P13N stuff 409 // P13N stuff
409 #ifdef CHROME_PERSONALIZATION 410 #ifdef CHROME_PERSONALIZATION
410 FramePersonalization personalization_; 411 FramePersonalization personalization_;
411 bool personalization_enabled_; 412 bool personalization_enabled_;
412 #endif 413 #endif
413 414
414 DISALLOW_EVIL_CONSTRUCTORS(BrowserView); 415 DISALLOW_EVIL_CONSTRUCTORS(BrowserView);
415 }; 416 };
416 417
417 #endif // #ifndef CHROME_BROWSER_VIEWS_FRAME_BROWSER_VIEW_H_ 418 #endif // #ifndef CHROME_BROWSER_VIEWS_FRAME_BROWSER_VIEW_H_
OLDNEW
« no previous file with comments | « chrome/browser/dock_info.cc ('k') | chrome/browser/views/frame/browser_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698