Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: chrome/browser/browser_window_cocoa.mm

Issue 18540: Don't expose the go and star button views directly through the BrowserWindow ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/browser_window_cocoa.h ('k') | chrome/browser/dock_info.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/gfx/rect.h" 5 #include "base/gfx/rect.h"
6 #include "chrome/browser/browser_window_cocoa.h" 6 #include "chrome/browser/browser_window_cocoa.h"
7 #include "chrome/browser/browser_window_controller.h" 7 #include "chrome/browser/browser_window_controller.h"
8 8
9 BrowserWindowCocoa::BrowserWindowCocoa(BrowserWindowController* controller, 9 BrowserWindowCocoa::BrowserWindowCocoa(BrowserWindowController* controller,
10 NSWindow* window) 10 NSWindow* window)
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 } 44 }
45 45
46 void* BrowserWindowCocoa::GetNativeHandle() { 46 void* BrowserWindowCocoa::GetNativeHandle() {
47 return [controller_ window]; 47 return [controller_ window];
48 } 48 }
49 49
50 BrowserWindowTesting* BrowserWindowCocoa::GetBrowserWindowTesting() { 50 BrowserWindowTesting* BrowserWindowCocoa::GetBrowserWindowTesting() {
51 return NULL; 51 return NULL;
52 } 52 }
53 53
54 TabStrip* BrowserWindowCocoa::GetTabStrip() const {
55 return NULL;
56 }
57
58 StatusBubble* BrowserWindowCocoa::GetStatusBubble() { 54 StatusBubble* BrowserWindowCocoa::GetStatusBubble() {
59 return NULL; 55 return NULL;
60 } 56 }
61 57
62 void BrowserWindowCocoa::SelectedTabToolbarSizeChanged(bool is_animating) { 58 void BrowserWindowCocoa::SelectedTabToolbarSizeChanged(bool is_animating) {
63 } 59 }
64 60
65 void BrowserWindowCocoa::UpdateTitleBar() { 61 void BrowserWindowCocoa::UpdateTitleBar() {
66 } 62 }
67 63
68 void BrowserWindowCocoa::UpdateLoadingAnimations(bool should_animate) { 64 void BrowserWindowCocoa::UpdateLoadingAnimations(bool should_animate) {
69 } 65 }
70 66
67 void BrowserWindowCocoa::SetStarredState(bool is_starred) {
68 }
69
71 gfx::Rect BrowserWindowCocoa::GetNormalBounds() const { 70 gfx::Rect BrowserWindowCocoa::GetNormalBounds() const {
72 // TODO(pinkerton): not sure if we can get the non-zoomed bounds, or if it 71 // TODO(pinkerton): not sure if we can get the non-zoomed bounds, or if it
73 // really matters. We may want to let Cocoa handle all this for us. 72 // really matters. We may want to let Cocoa handle all this for us.
74 NSRect frame = [window_ frame]; 73 NSRect frame = [window_ frame];
75 NSScreen* screen = [window_ screen]; 74 NSScreen* screen = [window_ screen];
76 gfx::Rect bounds(frame.origin.x, 0, frame.size.width, frame.size.height); 75 gfx::Rect bounds(frame.origin.x, 0, frame.size.width, frame.size.height);
77 bounds.set_y([screen frame].size.height + frame.size.height + frame.origin.y); 76 bounds.set_y([screen frame].size.height + frame.size.height + frame.origin.y);
78 return bounds; 77 return bounds;
79 } 78 }
80 79
(...skipping 10 matching lines...) Expand all
91 } 90 }
92 91
93 GoButton* BrowserWindowCocoa::GetGoButton() const { 92 GoButton* BrowserWindowCocoa::GetGoButton() const {
94 return NULL; 93 return NULL;
95 } 94 }
96 95
97 BookmarkBarView* BrowserWindowCocoa::GetBookmarkBarView() { 96 BookmarkBarView* BrowserWindowCocoa::GetBookmarkBarView() {
98 return NULL; 97 return NULL;
99 } 98 }
100 99
100 void BrowserWindowCocoa::UpdateStopGoState(bool is_loading) {
101 }
102
101 void BrowserWindowCocoa::UpdateToolbar(TabContents* contents, 103 void BrowserWindowCocoa::UpdateToolbar(TabContents* contents,
102 bool should_restore_state) { 104 bool should_restore_state) {
103 } 105 }
104 106
105 void BrowserWindowCocoa::FocusToolbar() { 107 void BrowserWindowCocoa::FocusToolbar() {
106 } 108 }
107 109
108 bool BrowserWindowCocoa::IsBookmarkBarVisible() const { 110 bool BrowserWindowCocoa::IsBookmarkBarVisible() const {
109 return true; 111 return true;
110 } 112 }
111 113
112 void BrowserWindowCocoa::ToggleBookmarkBar() { 114 void BrowserWindowCocoa::ToggleBookmarkBar() {
113 } 115 }
114 116
115 void BrowserWindowCocoa::ShowAboutChromeDialog() { 117 void BrowserWindowCocoa::ShowAboutChromeDialog() {
116 } 118 }
117 119
118 void BrowserWindowCocoa::ShowBookmarkManager() { 120 void BrowserWindowCocoa::ShowBookmarkManager() {
119 } 121 }
120 122
123 bool BrowserWindowCocoa::IsBookmarkBubbleVisible() const {
124 }
125
126 void BrowserWindowCocoa::ShowBookmarkBubble(const GURL& url,
127 bool already_bookmarked) {
128 }
129
121 void BrowserWindowCocoa::ShowReportBugDialog() { 130 void BrowserWindowCocoa::ShowReportBugDialog() {
122 } 131 }
123 132
124 void BrowserWindowCocoa::ShowClearBrowsingDataDialog() { 133 void BrowserWindowCocoa::ShowClearBrowsingDataDialog() {
125 } 134 }
126 135
127 void BrowserWindowCocoa::ShowImportDialog() { 136 void BrowserWindowCocoa::ShowImportDialog() {
128 } 137 }
129 138
130 void BrowserWindowCocoa::ShowSearchEnginesDialog() { 139 void BrowserWindowCocoa::ShowSearchEnginesDialog() {
131 } 140 }
132 141
133 void BrowserWindowCocoa::ShowPasswordManager() { 142 void BrowserWindowCocoa::ShowPasswordManager() {
134 } 143 }
135 144
136 void BrowserWindowCocoa::ShowHTMLDialog(HtmlDialogContentsDelegate* delegate, 145 void BrowserWindowCocoa::ShowHTMLDialog(HtmlDialogContentsDelegate* delegate,
137 void* parent_window) { 146 void* parent_window) {
138 } 147 }
139 148
140 void BrowserWindowCocoa::DestroyBrowser() { 149 void BrowserWindowCocoa::DestroyBrowser() {
141 [controller_ destroyBrowser]; 150 [controller_ destroyBrowser];
142 151
143 // at this point the controller is dead (autoreleased), so 152 // at this point the controller is dead (autoreleased), so
144 // make sure we don't try to reference it any more. 153 // make sure we don't try to reference it any more.
145 } 154 }
OLDNEW
« no previous file with comments | « chrome/browser/browser_window_cocoa.h ('k') | chrome/browser/dock_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698