Issue 1853: Refactor the platform canvas unit test a bit so that it can be run on...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1853: Refactor the platform canvas unit test a bit so that it can be run on... (Closed)

Created:
12 years, 3 months ago by Amanda Walker

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Refactor the platform canvas unit test a bit so that it can be run on multiple platforms. Also adjusts platfom_canvas.h and platform_device.h so that some upper layers can include them instead of the windows versions. Change was originally http://codereview.chromium.org/1616, which was created in the wrong source tree. Applying approval from that issue. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=1926

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -286 lines)			Patch
M	base/base.xcodeproj/project.pbxproj	View	7 chunks	+10 lines, -0 lines	0 comments	Download
M	base/build/base_unittests.vcproj	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/gfx/SConscript	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/gfx/bitmap_platform_device.h	View	1 chunk	+9 lines, -4 lines	0 comments	Download
M	base/gfx/bitmap_platform_device_mac.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	base/gfx/platform_canvas.h	View	1 chunk	+13 lines, -5 lines	0 comments	Download
M	base/gfx/platform_canvas_mac.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
D	base/gfx/platform_canvas_unittest_win.cc	View	1 chunk	+0 lines, -269 lines	0 comments	Download
M	base/gfx/platform_device.h	View	1 chunk	+10 lines, -5 lines	0 comments	Download
M	base/gfx/platform_device_mac.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download