Refactor the platform canvas unit test a bit so that it can be run on...

Refactor the platform canvas unit test a bit so that it can be run on
multiple platforms.  Also adjusts platfom_canvas.h and platform_device.h
so that some upper layers can include them instead of the windows versions.

[Evan Martin, 2008-09-08 17:58:57]

http://codereview.chromium.org/1616/diff/1/5
File base/gfx/bitmap_platform_device.h (right):

http://codereview.chromium.org/1616/diff/1/5#newcode24
Line 24: #include "base/gfx/bitmap_platform_device_mac.h"
Should this be _linux?

http://codereview.chromium.org/1616/diff/1/11
File base/gfx/platform_canvas_unittest.cc (right):

http://codereview.chromium.org/1616/diff/1/11#newcode86
Line 86: #error implement DrawNativeRect!
NOTIMPLEMENTED()
?

http://codereview.chromium.org/1616/diff/1/12
File base/gfx/platform_device_mac.h (right):

http://codereview.chromium.org/1616/diff/1/12#newcode62
Line 62: // on platforms where the native rendering API does not support
rendering
s/on/On/

[Evan Martin, 2008-09-08 18:11:50]

LGTM with one more

http://codereview.chromium.org/1616/diff/205/34
File base/gfx/platform_canvas_unittest.cc (right):

http://codereview.chromium.org/1616/diff/205/34#newcode62
Line 62: void DrawNativeRect(PlatformCanvas& canvas, int x, int y, int w, int h)
{
Oh, one more, sorry: this first arg should either be a const ref or a pointer --
no plain refs allowed.  :)

[brettw, 2008-09-08 18:18:17]

I only skimmed it and didn't notice anything wrong. I defer to Evan's detailed
review.

[pink (ping after 24hrs), 2008-09-08 18:25:33]

http://codereview.chromium.org/1616/diff/205/33
File base/gfx/platform_device.h (right):

http://codereview.chromium.org/1616/diff/205/33#newcode17
Line 17: #elif defined(OS_WIN)
hrm, i think this is a typo. two defined(OS_WIN) sections?

[cesar.alaniz, 2008-09-08 18:56:14]

Just a comment.

http://codereview.chromium.org/1616/diff/205/30
File base/gfx/platform_canvas.h (right):

http://codereview.chromium.org/1616/diff/205/30#newcode21
Line 21: 
This is a style comment.  Its clearer if you move the namespace declaration
outside the preprocessor directives. much like the original was.  Also would be
nicer to clearly see the header includes at the top with a separate preprocessor
include for each.  Could apply this to the other files too.

http://codereview.chromium.org/1616/diff/205/33
File base/gfx/platform_device.h (right):

http://codereview.chromium.org/1616/diff/205/33#newcode17
Line 17: #elif defined(OS_WIN)
On 2008/09/08 18:25:34, pink wrote:
> hrm, i think this is a typo. two defined(OS_WIN) sections?

Done.

[Evan Martin, 2008-09-09 19:24:42]

If this is checked in, would you mind closing this issue?
Go do "Edit issue" on the left, pick the "closed" checkbox, and save.

[Amanda Walker, 2008-09-09 19:50:57]

Redirected to http://codereview.chromium.org/1853 for commit (having svn
problems in the original tree).  Applying the LGTMs from 1616.