Call logging::InitLogging. The lack of this was causing some hangs (and poss...

Call logging::InitLogging.  The lack of this was causing some hangs (and possibly crashes) in ObserverListTest.BUG=6286
This CL has expanded to include some cleanup and refactoring of test_suite and related files, so that this logging change (and other improvements) are applied to all unit tests.



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7977

[darin (slow to review), 2009-01-13 17:37:47]

can this be part of the TestSuite constructor instead?

[darin (slow to review), 2009-01-13 17:38:14]

http://codereview.chromium.org/18003/diff/1/2
File base/run_all_unittests.cc (right):

http://codereview.chromium.org/18003/diff/1/2#newcode13
Line 13: base::EnableTerminationOnHeapCorruption();
i also don't understand why this function call is not in the TestSuite
constructor.

[Erik does not do reviews, 2009-01-13 19:37:42]

On 2009/01/13 17:37:47, darin wrote:
> can this be part of the TestSuite constructor instead?

Of course.  Your seemingly innocent questions have a way of causing CL's to grow
significantly. ;-)

[Erik does not do reviews, 2009-01-13 19:41:46]

On 2009/01/13 19:37:42, Erik Kay wrote:
> On 2009/01/13 17:37:47, darin wrote:
> > can this be part of the TestSuite constructor instead?
> 
> Of course.  Your seemingly innocent questions have a way of causing CL's to
grow
> significantly. ;-)

New snapshot uploaded.

[darin (slow to review), 2009-01-13 20:04:27]

LG, but...

http://codereview.chromium.org/18003/diff/210/213
File base/base_paths.h (right):

http://codereview.chromium.org/18003/diff/210/213#newcode19
Line 19: #include "base/path_service.h"
this change doesn't seem necessary...

http://codereview.chromium.org/18003/diff/210/222
File chrome/test/perf/perftests.cc (right):

http://codereview.chromium.org/18003/diff/210/222#newcode6
Line 6: #include "base/perf_test_suite.h"
looks like perf_test_suite.h is missing from this CL..

[Erik does not do reviews, 2009-01-13 20:28:12]

http://codereview.chromium.org/18003/diff/210/213
File base/base_paths.h (right):

http://codereview.chromium.org/18003/diff/210/213#newcode19
Line 19: #include "base/path_service.h"
On 2009/01/13 20:04:27, darin wrote:
> this change doesn't seem necessary... 

Agree that it's not necessary to this CL, but the reason I added it was that
it's been bugging me for a while (and I ran into it again).  The issue is that
you never need *_paths.h without also using path_service.h.  Likewise, you never
need path_service.h without also including a *_paths.h function.  While I'm all
for modularity in header files, this one seems like a clear win.

http://codereview.chromium.org/18003/diff/210/222
File chrome/test/perf/perftests.cc (right):

http://codereview.chromium.org/18003/diff/210/222#newcode6
Line 6: #include "base/perf_test_suite.h"
On 2009/01/13 20:04:27, darin wrote:
> looks like perf_test_suite.h is missing from this CL..

good catch.  thanks.  (try bot caught it as well of course)

[darin (slow to review), 2009-01-13 20:31:45]

LGTM

[Erik does not do reviews, 2009-01-13 21:27:27]

There was a POSIX test failure in process_util.  +jeremy to review the change to
process_util_unittest.cc (it passes now).

[jeremy, 2009-01-13 21:32:53]

lgtm