base/process_util_unittest.cc - Issue 18003: Call logging::InitLogging. The lack of this was causing some hangs (and poss...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/process_util_unittest.cc

Issue 18003: Call logging::InitLogging. The lack of this was causing some hangs (and poss... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 11 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/process_util_unittest.cc

===================================================================

--- base/process_util_unittest.cc (revision 7931)

+++ base/process_util_unittest.cc (working copy)

@@ -159,11 +159,13 @@

}

+ // InitLogging always opens a file at startup.

+ int expected_num_open_fds = 1;

#if defined(OS_LINUX)

// On Linux, '/etc/localtime' is opened before the test's main() enters.

- const int expected_num_open_fds = 1;

+ expected_num_open_fds += 1;

+#endif // defined(OS_LINUX)

num_open_files -= expected_num_open_fds;

-#endif // defined(OS_LINUX)

write(write_pipe, &num_open_files, sizeof(num_open_files));

close(write_pipe);

« no previous file with comments | « base/perftimer.cc ('k') | base/run_all_perftests.cc » ('j') | no next file with comments »