Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Side by Side Diff: base/perftimer.cc

Issue 18003: Call logging::InitLogging. The lack of this was causing some hangs (and poss... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/perftimer.h ('k') | base/process_util_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/perftimer.h" 5 #include "base/perftimer.h"
6 6
7 #include <stdio.h> 7 #include <stdio.h>
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
11 #include "base/file_path.h"
11 #include "base/file_util.h" 12 #include "base/file_util.h"
12 #include "base/logging.h" 13 #include "base/logging.h"
13 14
14 static FILE* perf_log_file = NULL; 15 static FILE* perf_log_file = NULL;
15 16
16 bool InitPerfLog(const char* log_file) { 17 bool InitPerfLog(const FilePath& log_file) {
17 if (perf_log_file) { 18 if (perf_log_file) {
18 // trying to initialize twice 19 // trying to initialize twice
19 NOTREACHED(); 20 NOTREACHED();
20 return false; 21 return false;
21 } 22 }
22 23
23 perf_log_file = file_util::OpenFile(std::string(log_file), "w"); 24 perf_log_file = file_util::OpenFile(log_file, "w");
24 return perf_log_file != NULL; 25 return perf_log_file != NULL;
25 } 26 }
26 27
27 void FinalizePerfLog() { 28 void FinalizePerfLog() {
28 if (!perf_log_file) { 29 if (!perf_log_file) {
29 // trying to cleanup without initializing 30 // trying to cleanup without initializing
30 NOTREACHED(); 31 NOTREACHED();
31 return; 32 return;
32 } 33 }
33 file_util::CloseFile(perf_log_file); 34 file_util::CloseFile(perf_log_file);
34 } 35 }
35 36
36 void LogPerfResult(const char* test_name, double value, const char* units) { 37 void LogPerfResult(const char* test_name, double value, const char* units) {
37 if (!perf_log_file) { 38 if (!perf_log_file) {
38 NOTREACHED(); 39 NOTREACHED();
39 return; 40 return;
40 } 41 }
41 42
42 fprintf(perf_log_file, "%s\t%g\t%s\n", test_name, value, units); 43 fprintf(perf_log_file, "%s\t%g\t%s\n", test_name, value, units);
43 printf("%s\t%g\t%s\n", test_name, value, units); 44 printf("%s\t%g\t%s\n", test_name, value, units);
44 } 45 }
OLDNEW
« no previous file with comments | « base/perftimer.h ('k') | base/process_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698