Issue 1774005: GTK: The cookie prompt should allow the user to set expire date for HTML cookies

Issue 1774005: GTK: The cookie prompt should allow the user to set expire date for HTML cookies (Closed)

Created:
10 years, 7 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
tony, Evan Stade

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
git://codf21.jail.google.com/chromium.git

Visibility:
Public.

Description

GTK: The cookie prompt should allow the user to set expire date for HTML cookies BUG=42403 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45818

Patch Set 2 : Fix tests #

Total comments: 3

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+175 lines, -78 lines)			Patch
M	chrome/browser/cookie_modal_dialog.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/cookie_modal_dialog_gtk.cc	View	2 chunks	+12 lines, -10 lines	0 comments	Download
M	chrome/browser/gtk/gtk_chrome_cookie_view.h	View	3 chunks	+12 lines, -1 line	1 comment	Download
M	chrome/browser/gtk/gtk_chrome_cookie_view.cc	View	10 chunks	+110 lines, -18 lines	0 comments	Download
M	chrome/browser/gtk/options/cookies_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/options/cookies_view.cc	View	3 chunks	+16 lines, -13 lines	0 comments	Download
M	chrome/browser/gtk/options/cookies_view_unittest.cc	View	1 chunk	+21 lines, -35 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

lgtm http://codereview.chromium.org/1774005/diff/3001/4004 File chrome/browser/gtk/gtk_chrome_cookie_view.h (right): http://codereview.chromium.org/1774005/diff/3001/4004#newcode70 chrome/browser/gtk/gtk_chrome_cookie_view.h:70: GtkWidget* cookie_expires_entry_; it seems that the code would ...

10 years, 7 months ago (2010-04-27 19:32:35 UTC) #2

Elliot Glaysher

http://codereview.chromium.org/1774005/diff/3001/4007 File chrome/browser/gtk/options/cookies_view_unittest.cc (right): http://codereview.chromium.org/1774005/diff/3001/4007#newcode77 chrome/browser/gtk/options/cookies_view_unittest.cc:77: display->local_storage_last_modified_entry_)); On 2010/04/27 19:32:35, Evan Stade wrote: > if ...

10 years, 7 months ago (2010-04-27 21:03:44 UTC) #3

Evan Stade

10 years, 7 months ago (2010-04-27 21:13:13 UTC) #4

On Tue, Apr 27, 2010 at 2:03 PM,  <erg@chromium.org> wrote:
>
> http://codereview.chromium.org/1774005/diff/3001/4007
> File chrome/browser/gtk/options/cookies_view_unittest.cc (right):
>
> http://codereview.chromium.org/1774005/diff/3001/4007#newcode77
> chrome/browser/gtk/options/cookies_view_unittest.cc:77:
> display->local_storage_last_modified_entry_));
> On 2010/04/27 19:32:35, Evan Stade wrote:
>>
>> if you line wrap in an arg list, I tihnk you are supposed to flush the
>
> extra
>>
>> args with the first arg
>
> I'm pretty sure this is correct. The emacs rules bend over backwards to
> enforce this case and they discuss the rational in the docstrings:
>
> http://google-styleguide.googlecode.com/svn/trunk/google-c-style.el
> (Search for "Current C expression")

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Function_Calls

make of that what you will

>
> http://codereview.chromium.org/1774005/show
>

Expand Messages | Collapse Messages