GTK: The cookie prompt should allow the user to set expire date for HTML cookies

chrome/browser/gtk/options/cookies_view_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/gtk/options/cookies_view.h"
 
 #include <string>
 #include <vector>
 
 #include <gtk/gtk.h>
@@ skipping 25 matching lines @@
         new MockBrowsingDataLocalStorageHelper(profile_.get());
     mock_browsing_data_appcache_helper_ =
         new MockBrowsingDataAppCacheHelper(profile_.get());
   }
 
   void CheckDetailsSensitivity(gboolean expected_cookies,
                                gboolean expected_database,
                                gboolean expected_local_storage,
                                gboolean expected_appcache,
                                const CookiesView& cookies_view) {
+    GtkChromeCookieView* display = GTK_CHROME_COOKIE_VIEW(
+        cookies_view.cookie_display_);
+
     // Cookies
     EXPECT_EQ(expected_cookies,
-              GTK_WIDGET_SENSITIVE(cookies_view.cookie_display_->
-                                   cookie_name_entry_));
+              GTK_WIDGET_SENSITIVE(display->cookie_name_entry_));
     EXPECT_EQ(expected_cookies,
-              GTK_WIDGET_SENSITIVE(cookies_view.cookie_display_->
-                                   cookie_content_entry_));
+              GTK_WIDGET_SENSITIVE(display->cookie_content_entry_));
     EXPECT_EQ(expected_cookies,
-              GTK_WIDGET_SENSITIVE(cookies_view.cookie_display_->
-                                   cookie_domain_entry_));
+              GTK_WIDGET_SENSITIVE(display->cookie_domain_entry_));
     EXPECT_EQ(expected_cookies,
-              GTK_WIDGET_SENSITIVE(cookies_view.cookie_display_->
-                                   cookie_path_entry_));
+              GTK_WIDGET_SENSITIVE(display->cookie_path_entry_));
     EXPECT_EQ(expected_cookies,
-              GTK_WIDGET_SENSITIVE(cookies_view.cookie_display_->
-                                   cookie_send_for_entry_));
+              GTK_WIDGET_SENSITIVE(display->cookie_send_for_entry_));
     EXPECT_EQ(expected_cookies,
-              GTK_WIDGET_SENSITIVE(cookies_view.cookie_display_->
-                                   cookie_created_entry_));
+              GTK_WIDGET_SENSITIVE(display->cookie_created_entry_));
     EXPECT_EQ(expected_cookies,
-              GTK_WIDGET_SENSITIVE(cookies_view.cookie_display_->
-                                   cookie_expires_entry_));
+              GTK_WIDGET_SENSITIVE(display->cookie_expires_entry_));
     // Database
     EXPECT_EQ(expected_database,
-              GTK_WIDGET_SENSITIVE(cookies_view.cookie_display_->
-                                   database_description_entry_));
+              GTK_WIDGET_SENSITIVE(display->database_description_entry_));
     EXPECT_EQ(expected_database,
-              GTK_WIDGET_SENSITIVE(cookies_view.cookie_display_->
-                                   database_size_entry_));
+              GTK_WIDGET_SENSITIVE(display->database_size_entry_));
     EXPECT_EQ(expected_database,
-              GTK_WIDGET_SENSITIVE(cookies_view.cookie_display_->
-                                   database_last_modified_entry_));
+              GTK_WIDGET_SENSITIVE(display->database_last_modified_entry_));
     // Local Storage
     EXPECT_EQ(expected_local_storage,
-              GTK_WIDGET_SENSITIVE(cookies_view.cookie_display_->
-                                   local_storage_origin_entry_));
+              GTK_WIDGET_SENSITIVE(display->local_storage_origin_entry_));
     EXPECT_EQ(expected_local_storage,
-              GTK_WIDGET_SENSITIVE(cookies_view.cookie_display_->
-                                   local_storage_size_entry_));
-    EXPECT_EQ(expected_local_storage,
-              GTK_WIDGET_SENSITIVE(cookies_view.cookie_display_->
-                                   local_storage_last_modified_entry_));
+              GTK_WIDGET_SENSITIVE(display->local_storage_size_entry_));
+    EXPECT_EQ(expected_local_storage, GTK_WIDGET_SENSITIVE(
+        display->local_storage_last_modified_entry_));

[Evan Stade, 2010/04/27 19:32:35]

if you line wrap in an arg list, I tihnk you are supposed to flush the extra
args with the first arg

[Elliot Glaysher, 2010/04/27 21:03:45]

I'm pretty sure this is correct. The emacs rules bend over backwards to enforce
this case and they discuss the rational in the docstrings:

http://google-styleguide.googlecode.com/svn/trunk/google-c-style.el (Search for
"Current C expression")

     // AppCache
     EXPECT_EQ(expected_appcache,
-              GTK_WIDGET_SENSITIVE(cookies_view.cookie_display_->
-                                   appcache_manifest_entry_));
+              GTK_WIDGET_SENSITIVE(display->appcache_manifest_entry_));
     EXPECT_EQ(expected_appcache,
-              GTK_WIDGET_SENSITIVE(cookies_view.cookie_display_->
-                                   appcache_size_entry_));
+              GTK_WIDGET_SENSITIVE(display->appcache_size_entry_));
     EXPECT_EQ(expected_appcache,
-              GTK_WIDGET_SENSITIVE(cookies_view.cookie_display_->
-                                   appcache_created_entry_));
+              GTK_WIDGET_SENSITIVE(display->appcache_created_entry_));
     EXPECT_EQ(expected_appcache,
-              GTK_WIDGET_SENSITIVE(cookies_view.cookie_display_->
-                                   appcache_last_accessed_entry_));
+              GTK_WIDGET_SENSITIVE(display->appcache_last_accessed_entry_));
   }
 
   // Get the cookie names in the cookie list, as a comma seperated string.
   // (Note that the CookieMonster cookie list is sorted by domain.)
   // Ex:
   //   monster->SetCookie(GURL("http://b"), "X=1")
   //   monster->SetCookie(GURL("http://a"), "Y=1")
   //   EXPECT_STREQ("Y,X", GetMonsterCookies(monster).c_str());
   std::string GetMonsterCookies(net::CookieMonster* monster) {
     std::vector<std::string> parts;
@@ skipping 1071 matching lines @@
     SCOPED_TRACE("First selection removed");
     EXPECT_STREQ("C,B", GetMonsterCookies(monster).c_str());
     EXPECT_STREQ("gdbhost1,_Web Databases,__db1,"
                  "host1,_Local Storage,__origin1",
                  GetDisplayedCookies(cookies_view).c_str());
     EXPECT_EQ(TRUE, GTK_WIDGET_SENSITIVE(cookies_view.remove_all_button_));
     EXPECT_EQ(FALSE, GTK_WIDGET_SENSITIVE(cookies_view.remove_button_));
     CheckDetailsSensitivity(FALSE, FALSE, FALSE, FALSE, cookies_view);
   }
 }