GTK: The cookie prompt should allow the user to set expire date for HTML cookies

chrome/browser/gtk/gtk_chrome_cookie_view.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_GTK_GTK_CHROME_COOKIE_VIEW_H_
 #define CHROME_BROWSER_GTK_GTK_CHROME_COOKIE_VIEW_H_
 
 #include <gtk/gtk.h>
 
 #include <string>
@@ skipping 45 matching lines @@
   GtkWidget* first_label_;
 
   // The cookie details widgets.
   GtkWidget* cookie_details_table_;
   GtkWidget* cookie_name_entry_;
   GtkWidget* cookie_content_entry_;
   GtkWidget* cookie_domain_entry_;
   GtkWidget* cookie_path_entry_;
   GtkWidget* cookie_send_for_entry_;
   GtkWidget* cookie_created_entry_;
+
+  // Note: These two widgets are mutually exclusive based on what
+  // |editable_expiration| was when the cookie view was created. One of these
+  // variables will be NULL.
   GtkWidget* cookie_expires_entry_;

[Evan Stade, 2010/04/27 19:32:35]

it seems that the code would be a little more self-documenting if you saved
editable_expiration into a member var, and combined these two widgets (because
then the check would be

if (editable_expiration_)

instead of

if (cookie_expires_entry_)

but it's up to you.

+  GtkWidget* cookie_expires_combobox_;
+
+  GtkListStore* cookie_expires_combobox_store_;
 
   // The database details widgets.
   GtkWidget* database_details_table_;
   GtkWidget* database_name_entry_;
   GtkWidget* database_description_entry_;
   GtkWidget* database_size_entry_;
   GtkWidget* database_last_modified_entry_;
 
   // The local storage details widgets.
   GtkWidget* local_storage_details_table_;
@@ skipping 26 matching lines @@
   GtkWidget* appcache_created_manifest_entry_;
 } GtkChromeCookieView;
 
 typedef struct {
   GtkFrameClass parent_class;
 } GtkChromeCookieViewClass;
 
 GType gtk_chrome_cookie_view_get_type();
 
 // Builds a new cookie view.
-GtkChromeCookieView* gtk_chrome_cookie_view_new();
+GtkWidget* gtk_chrome_cookie_view_new(gboolean editable_expiration);
 
 // Clears the cookie view.
 void gtk_chrome_cookie_view_clear(GtkChromeCookieView* widget);
 
 // NOTE: The G_END_DECLS ends here instead of at the end of the document
 // because we want to define some methods on GtkChromeCookieView that take C++
 // objects.
 G_END_DECLS
 // NOTE: ^^^^^^^^^^^^^^^^^^^^^^^
 
@@ skipping 36 matching lines @@
     GtkChromeCookieView* self,
     const std::string& host,
     const string16& database_name,
     const string16& display_name,
     unsigned long estimated_size);
 
 void gtk_chrome_cookie_view_display_appcache_created(
     GtkChromeCookieView* self,
     const GURL& manifest_url);
 
+// If |editable_expiration| was true at construction time, returns the value of
+// the combo box. Otherwise, returns false.
+bool gtk_chrome_cookie_view_session_expires(GtkChromeCookieView* self);
+
 #endif  // CHROME_BROWSER_GTK_GTK_CHROME_COOKIE_VIEW_H_