Re-apply http://codereview.chromium.org/1622012

Re-apply http://codereview.chromium.org/1622012
It was reverted as http://codereview.chromium.org/1822001 the fix in Valgrind scripts has been commited as http://codereview.chromium.org/1736026
TEST=trybots

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46070

[Alexander Potapenko, 2010-04-30 13:47:15]

On 2010/04/30 13:43:12, Timur Iskhodzhanov wrote:
> 

LGTM assuming this is the same patch as Nick's

[Paweł Hajdan Jr., 2010-04-30 13:52:27]

Make sure that you have green trybot runs for at least linux, mac, win (and
their release versions), and the valgrind trybots.

After that, LGTM!

[Timur Iskhodzhanov, 2010-04-30 13:57:15]

Sure.

Actually, you may notice that the tryjobs at the fix-CL
http://codereview.chromium.org/1736026 were run against the revisions before
your revert :-)
But anyway, I'll wait for a few tryjobs to finish
On 2010/04/30 13:52:27, Paweł Hajdan Jr. wrote:
> Make sure that you have green trybot runs for at least linux, mac, win (and
> their release versions), and the valgrind trybots.
> 
> After that, LGTM!

[ncarter (slow), 2010-04-30 16:40:53]

Thanks for making this work, and sorry for not catching it myself.

FWIW: The protobuf standard library uses pkg_resources from setuptools to
declare a namespace package to deal with precisely this conflict.  There was
some discussion of that here:
https://groups.google.com/group/protobuf/browse_thread/thread/401e6e54e6b4657...

I think we might just want to move to using pkg_resources to deal with the
'google' package collision. Python 2.6 includes pkg_resources by default,
but I imagine upgrading might be tricker than just pulling in a library.

 - nick

On Fri, Apr 30, 2010 at 6:57 AM, <timurrrr@chromium.org> wrote:

> Sure.
>
> Actually, you may notice that the tryjobs at the fix-CL
> http://codereview.chromium.org/1736026 were run against the revisions
> before
> your revert :-)
> But anyway, I'll wait for a few tryjobs to finish
>
> On 2010/04/30 13:52:27, Paweł Hajdan Jr. wrote:
>
>> Make sure that you have green trybot runs for at least linux, mac, win
>> (and
>> their release versions), and the valgrind trybots.
>>
>
>  After that, LGTM!
>>
>
>
>
> http://codereview.chromium.org/1763023/show
>