Issue 1736026: Change PYTHONPATH handling in tools/valgrind so we can un-revert http://coder...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1736026: Change PYTHONPATH handling in tools/valgrind so we can un-revert http://coder... (Closed)

Created:
10 years, 7 months ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Lei Zhang, Alexander Potapenko, Paweł Hajdan Jr.

CC:
chromium-reviews, stuartmorgan, pam+watch_chromium.org, ncarter (slow)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Change PYTHONPATH handling in tools/valgrind so we can un-revert http://codereview.chromium.org/1822001 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46052

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
M	tools/valgrind/chrome_tests.bat	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/valgrind/chrome_tests.py	View		5 chunks	+7 lines, -7 lines	0 comments	Download
M	tools/valgrind/chrome_tests.sh	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/valgrind/valgrind_test.py	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

CC-ing Nick just for his info. LGTM, thanks for investigating this. Please make sure to ...

10 years, 7 months ago (2010-04-30 09:13:50 UTC) #2

Timur Iskhodzhanov

Post-mortem for Valgrind failures after http://codereview.chromium.org/1622012 : Valgrind runner scripts used "import google.logging_utils" and "import ...

10 years, 7 months ago (2010-04-30 09:17:07 UTC) #3

Alexander Potapenko

10 years, 7 months ago (2010-04-30 09:22:28 UTC) #4

LGTM
On 2010/04/30 09:17:07, Timur Iskhodzhanov wrote:
> Post-mortem for Valgrind failures after http://codereview.chromium.org/1622012
:
> Valgrind runner scripts used "import google.logging_utils" and "import
> google.path_utils".
> Nick's commit was adding google.protobuf to another directory.
> We used PYTHONPATH=$SRC/tools/python when running Valgrind, so Python tried to
> find protobuf.py in tools/python/google when looking up for google.protobuf

Expand Messages | Collapse Messages