Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issue 1822001: Revert "[Third time landing] Python implementation of sync server, for testing." (Closed)

Created:
10 years, 7 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, Alexander Potapenko, bradnelson, Zachary Kuznia
Visibility:
Public.

Description

Revert "[Third time landing] Python implementation of sync server, for testing." This broke the memory waterfall, failed to import protobuf. TBR=nick Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46048

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -2435 lines) Patch
M chrome/browser/sync/profile_sync_service.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/sync/protocol/sync_proto.gyp View 1 chunk +0 lines, -73 lines 0 comments Download
M chrome/chrome.gyp View 3 chunks +54 lines, -4 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 5 chunks +5 lines, -7 lines 0 comments Download
M chrome/test/in_process_browser_test.h View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/test/in_process_browser_test.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M chrome/test/live_sync/live_sync_test.h View 3 chunks +0 lines, -23 lines 0 comments Download
M chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc View 8 chunks +24 lines, -18 lines 0 comments Download
M chrome/test/memory_test/memory_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/net.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M net/socket/ssl_test_util.cc View 2 chunks +1 line, -8 lines 0 comments Download
D net/tools/testserver/chromiumsync.py View 1 chunk +0 lines, -653 lines 0 comments Download
D net/tools/testserver/chromiumsync_test.py View 1 chunk +0 lines, -317 lines 0 comments Download
M net/tools/testserver/testserver.py View 7 chunks +3 lines, -58 lines 0 comments Download
D third_party/protobuf2/__init__.py View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/protobuf2/descriptor_pb2.py View 1 chunk +0 lines, -1172 lines 0 comments Download
M third_party/protobuf2/protobuf.gyp View 2 chunks +0 lines, -81 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Paweł Hajdan Jr.
10 years, 7 months ago (2010-04-30 08:23:37 UTC) #1
Sorry for making the third landing fail, but I and glider failed to resolve the
redness (please make sure to watch the tree after landing "risky" patches, that
could have saved it).

Also, could you split the patch so that it's more safe to land?

Here are some logs from the failure on the memory waterfall.

[----------] 1 test from ViewSourceTest
[ RUN      ] ViewSourceTest.ViewSourceInPageMenuDisabledWhileViewingSource
[2525:2525:0429/231927:11254181032969:INFO:chrome/test/ui/ui_test.cc(1206)]
BROWSER_WRAPPER was set, prefixing command_line with
/b/slave/chromium-rel-linux-valgrind-tests-2/build/valgrind.tmp/browser_wrapper.JDSvpm
[2525:2525:0429/231959:11254212802330:INFO:net/socket/ssl_test_util.cc(205)]
Trying to launch python ...
Traceback (most recent call last):
  File
"/b/slave/chromium-rel-linux-valgrind-tests-2/build/src/net/tools/testserver/testserver.py",
line 31, in <module>
    import chromiumsync
  File
"/b/slave/chromium-rel-linux-valgrind-tests-2/build/src/net/tools/testserver/chromiumsync.py",
line 16, in <module>
    import autofill_specifics_pb2
  File
"/b/slave/chromium-rel-linux-valgrind-tests-2/build/src/sconsbuild/Release/pyproto/sync_pb/autofill_specifics_pb2.py",
line 3, in <module>
    from google.protobuf import descriptor
ImportError: No module named protobuf
[2525:2525:0429/232009:11254222810398:ERROR:net/socket/ssl_test_util.cc(216)]
Failed to connect to server
[2525:2525:0429/232009:11254222811003:INFO:net/socket/ssl_test_util.cc(269)]
Stopped.
chrome/browser/tab_contents/view_source_uitest.cc:100: Failure
Value of: NULL != server.get()
  Actual: false
Expected: true
[  FAILED  ] ViewSourceTest.ViewSourceInPageMenuDisabledWhileViewingSource
(51281 ms)
[----------] 1 test from ViewSourceTest (51281 ms total)

[----------] 2 tests from URLFetcherTest
[ RUN      ] URLFetcherTest.SameThreadsTest
[54070:1291:0430/001726:4202529365580950:INFO:/b/slave/chromium-dbg-mac-valgrind/build/src/net/socket/ssl_test_util.cc(205)]
Trying to launch python ...
UNKNOWN task message [id 3413, to mach_task_self(), reply 0x903]
Traceback (most recent call last):
  File
"/b/slave/chromium-dbg-mac-valgrind/build/src/net/tools/testserver/testserver.py",
line 31, in <module>
    import chromiumsync
  File
"/b/slave/chromium-dbg-mac-valgrind/build/src/net/tools/testserver/chromiumsync.py",
line 16, in <module>
    import autofill_specifics_pb2
  File
"/b/slave/chromium-dbg-mac-valgrind/build/src/xcodebuild/Debug/pyproto/sync_pb/autofill_specifics_pb2.py",
line 3, in <module>
    from google.protobuf import descriptor
ImportError: No module named protobuf
[54070:1291:0430/001737:4202539853874064:ERROR:/b/slave/chromium-dbg-mac-valgrind/build/src/net/socket/ssl_test_util.cc(216)]
Failed to connect to server
[54070:1291:0430/001737:4202539857759505:INFO:/b/slave/chromium-dbg-mac-valgrind/build/src/net/socket/ssl_test_util.cc(269)]
Stopped.
/b/slave/chromium-dbg-mac-valgrind/build/src/chrome/browser/net/url_fetcher_unittest.cc:416:
Failure
Value of: NULL != server.get()
  Actual: false
Expected: true
[  FAILED  ] URLFetcherTest.SameThreadsTest (10615 ms)

http://build.chromium.org/buildbot/memory/builders/Linux%20Tests%20%28valgrin...

http://build.chromium.org/buildbot/memory/builders/Linux%20Tests%20%28valgrin...

http://build.chromium.org/buildbot/memory/builders/Linux%20Tests%20%28valgrin...

http://build.chromium.org/buildbot/memory/builders/Linux%20Tests%20%28valgrin...

http://build.chromium.org/buildbot/memory/builders/Linux%20Tests%20%28tsan%29...

http://build.chromium.org/buildbot/memory/builders/Linux%20Tests%20%28tsan%29...

http://build.chromium.org/buildbot/memory/builders/Webkit%20Linux%20%28valgri...

http://build.chromium.org/buildbot/memory/builders/Webkit%20Mac%20%28valgrind...

http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20%28valgri...

http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20%28valgri...

http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20%28tsan%2...

http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20UI%20%28v...

http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20UI%20%28v...

http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20UI%20%28v...

http://build.chromium.org/buildbot/memory/builders/Chromium%20OS%20UI%20%28va...

Powered by Google App Engine
This is Rietveld 408576698