Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 173480: DevTools: Remove base/values dependency from devtools. (Closed)

Created:
11 years, 4 months ago by pfeldman
Modified:
9 years, 7 months ago
Reviewers:
yurys
CC:
chromium-reviews_googlegroups.com, darin (slow to review)
Visibility:
Public.

Description

DevTools: Remove base/values dependency from devtools.

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 9

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -631 lines) Patch
M chrome/browser/debugger/inspectable_tab_proxy.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/debugger/inspectable_tab_proxy.cc View 1 2 3 2 chunks +5 lines, -19 lines 0 comments Download
M chrome/browser/extensions/extension_devtools_bridge.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_devtools_bridge.cc View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/common/devtools_messages_internal.h View 1 2 3 2 chunks +8 lines, -4 lines 0 comments Download
M chrome/renderer/devtools_agent.h View 1 2 3 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/renderer/devtools_agent.cc View 1 2 3 2 chunks +10 lines, -4 lines 0 comments Download
M chrome/renderer/devtools_client.h View 1 2 3 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/renderer/devtools_client.cc View 1 2 3 2 chunks +10 lines, -4 lines 0 comments Download
M webkit/glue/devtools/debugger_agent.h View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M webkit/glue/devtools/debugger_agent_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/devtools/debugger_agent_manager.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/devtools/devtools_mock_rpc.h View 1 2 3 1 chunk +0 lines, -91 lines 0 comments Download
M webkit/glue/devtools/devtools_rpc.h View 1 2 3 10 chunks +72 lines, -175 lines 0 comments Download
M webkit/glue/devtools/devtools_rpc.cc View 1 2 3 1 chunk +0 lines, -109 lines 0 comments Download
M webkit/glue/devtools/devtools_rpc_js.h View 1 2 3 5 chunks +20 lines, -36 lines 0 comments Download
M webkit/glue/devtools/devtools_rpc_unittest.cc View 1 2 3 1 chunk +0 lines, -130 lines 0 comments Download
M webkit/glue/devtools/js/devtools.js View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/glue/devtools/tools_agent.h View 1 2 3 3 chunks +3 lines, -5 lines 0 comments Download
M webkit/glue/webdevtoolsagent.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M webkit/glue/webdevtoolsagent_delegate.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M webkit/glue/webdevtoolsagent_impl.h View 1 2 3 1 chunk +6 lines, -2 lines 0 comments Download
M webkit/glue/webdevtoolsagent_impl.cc View 1 2 3 4 chunks +10 lines, -8 lines 0 comments Download
M webkit/glue/webdevtoolsclient.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M webkit/glue/webdevtoolsclient_delegate.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M webkit/glue/webdevtoolsclient_impl.h View 1 2 3 4 2 chunks +8 lines, -4 lines 0 comments Download
M webkit/glue/webdevtoolsclient_impl.cc View 1 2 3 4 chunks +37 lines, -17 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gyp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M webkit/webkit.gyp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
pfeldman
11 years, 4 months ago (2009-08-26 16:51:36 UTC) #1
yurys
11 years, 3 months ago (2009-08-27 15:11:48 UTC) #2 
LGTM with comments

http://codereview.chromium.org/173480/diff/75/1041
File chrome/renderer/devtools_agent.cc (right):

http://codereview.chromium.org/173480/diff/75/1041#newcode52
Line 52: DevToolsClientMsg_RpcMessage(class_name, method_name, param1, param2,
style: wrong alignment

http://codereview.chromium.org/173480/diff/75/1041#newcode96
Line 96: web_agent->DispatchMessageFromClient(class_name, method_name, param1,
style: wrong alignment

http://codereview.chromium.org/173480/diff/75/1040
File chrome/renderer/devtools_client.cc (right):

http://codereview.chromium.org/173480/diff/75/1040#newcode51
Line 51: Send(DevToolsAgentMsg_RpcMessage(class_name, method_name, param1,
param2,
ditto

http://codereview.chromium.org/173480/diff/75/1040#newcode90
Line 90: web_tools_client_->DispatchMessageFromAgent(class_name, method_name,
param1,
ditto

http://codereview.chromium.org/173480/diff/75/1025
File webkit/glue/devtools/devtools_rpc.h (right):

http://codereview.chromium.org/173480/diff/75/1025#newcode282
Line 282: class DevToolsRpc {
consider removing this class

http://codereview.chromium.org/173480/diff/75/1026
File webkit/glue/devtools/js/devtools.js (right):

http://codereview.chromium.org/173480/diff/75/1026#newcode20
Line 20: */
missin @param descriptions

http://codereview.chromium.org/173480/diff/75/1026#newcode34
Line 34: debugPrint(param1);
remove this code

http://codereview.chromium.org/173480/diff/75/1029
File webkit/glue/webdevtoolsclient_impl.cc (right):

http://codereview.chromium.org/173480/diff/75/1029#newcode203
Line 203: const std::string& param1,
why not use single parameter as before?

http://codereview.chromium.org/173480/diff/75/1029#newcode264
Line 264: delegate_->SendMessageToAgent(class_name, method_name, param1, param2,
wrong alignment

Powered by Google App Engine
This is Rietveld 408576698